Bug 53010

Summary: Move contentEditable related tests to fast/dom/HTMLElement
Product: WebKit Reporter: Chang Shu <cshu>
Component: DOMAssignee: Chang Shu <cshu>
Status: RESOLVED FIXED    
Severity: Normal CC: ademar, commit-queue, darin, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 52059    
Attachments:
Description Flags
fix patch
none
fix patch 2 none

Chang Shu
Reported 2011-01-24 07:43:00 PST
The best place to hold the contentEditable related tests is fast/dom/HTMLElement.
Attachments
fix patch (84.67 KB, patch)
2011-01-24 07:47 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
fix patch 2 (97.90 KB, patch)
2011-01-24 08:44 PST, Chang Shu 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chang Shu
Comment 1 2011-01-24 07:47:46 PST
Created attachment 79923 [details] fix patch This patch moves the tests to fast/dom/HTMLElement. Let me know if a subdirectory is preferred.
Ryosuke Niwa
Comment 2 2011-01-24 08:29:00 PST
Comment on attachment 79923 [details] fix patch I just realized that all of these tests are missing DOCTYPE. Could you add: <!DOCTYPE html> to the beginning of each test so that we can be in strict mode?
Chang Shu
Comment 3 2011-01-24 08:30:23 PST
(In reply to comment #2) > (From update of attachment 79923 [details]) > I just realized that all of these tests are missing DOCTYPE. Could you add: > <!DOCTYPE html> > to the beginning of each test so that we can be in strict mode? Sure. The paths to the js-test-pre.js are so incorrect and I will fix them.
Chang Shu
Comment 4 2011-01-24 08:44:45 PST
Created attachment 79928 [details] fix patch 2
WebKit Commit Bot
Comment 5 2011-01-24 09:40:47 PST
Comment on attachment 79928 [details] fix patch 2 Clearing flags on attachment: 79928 Committed r76528: <http://trac.webkit.org/changeset/76528>
WebKit Commit Bot
Comment 6 2011-01-24 09:40:52 PST
All reviewed patches have been landed. Closing bug.
Ademar Reis
Comment 7 2011-02-02 12:23:23 PST
Revision r76528 cherry-picked into qtwebkit-2.1.x with commit 3ed7d92 <http://gitorious.org/webkit/qtwebkit/commit/3ed7d92>
Note You need to log in before you can comment on or make changes to this bug.