Bug 53010 - Move contentEditable related tests to fast/dom/HTMLElement
Summary: Move contentEditable related tests to fast/dom/HTMLElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 52059
  Show dependency treegraph
 
Reported: 2011-01-24 07:43 PST by Chang Shu
Modified: 2011-02-02 12:23 PST (History)
4 users (show)

See Also:


Attachments
fix patch (84.67 KB, patch)
2011-01-24 07:47 PST, Chang Shu
no flags Details | Formatted Diff | Diff
fix patch 2 (97.90 KB, patch)
2011-01-24 08:44 PST, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-01-24 07:43:00 PST
The best place to hold the contentEditable related tests is fast/dom/HTMLElement.
Comment 1 Chang Shu 2011-01-24 07:47:46 PST
Created attachment 79923 [details]
fix patch

This patch moves the tests to fast/dom/HTMLElement. Let me know if a subdirectory is preferred.
Comment 2 Ryosuke Niwa 2011-01-24 08:29:00 PST
Comment on attachment 79923 [details]
fix patch

I just realized that all of these tests are missing DOCTYPE.  Could you add:
<!DOCTYPE html>
to the beginning of each test so that we can be in strict mode?
Comment 3 Chang Shu 2011-01-24 08:30:23 PST
(In reply to comment #2)
> (From update of attachment 79923 [details])
> I just realized that all of these tests are missing DOCTYPE.  Could you add:
> <!DOCTYPE html>
> to the beginning of each test so that we can be in strict mode?

Sure. The paths to the js-test-pre.js are so incorrect and I will fix them.
Comment 4 Chang Shu 2011-01-24 08:44:45 PST
Created attachment 79928 [details]
fix patch 2
Comment 5 WebKit Commit Bot 2011-01-24 09:40:47 PST
Comment on attachment 79928 [details]
fix patch 2

Clearing flags on attachment: 79928

Committed r76528: <http://trac.webkit.org/changeset/76528>
Comment 6 WebKit Commit Bot 2011-01-24 09:40:52 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Ademar Reis 2011-02-02 12:23:23 PST
Revision r76528 cherry-picked into qtwebkit-2.1.x with commit 3ed7d92 <http://gitorious.org/webkit/qtwebkit/commit/3ed7d92>