Bug 52982 – SVG is missing to-animation support for Path

• Component: SVG
• Status: RESOLVED FIXED

[Dirk Schulze]

SVG is missing to-animation support for Path. This also causes an ASSERT because of missing m_fromPath. Have a patch for it soon.

[Dirk Schulze]

Created attachment 79875 [details]
Patch

[Dirk Schulze]

The description in the test is wrong. I'd like fix it on landing on a positive review.

[Eric Seidel (no email)]

Comment on attachment 79875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79875&action=review

> Source/WebCore/svg/SVGAnimateElement.cpp:143
> +            SVGPathParserFactory* factory = SVGPathParserFactory::self();

I'm not familiar with this self() pattern.  Do we use this other places in WebCore?  I assume you're vending a shared instance here, but I thought we had other naming patterns for such.

> Source/WebCore/svg/SVGPathParserFactory.cpp:129
> +PassOwnPtr<SVGPathByteStream> SVGPathParserFactory::copySVGPathByteStream(SVGPathByteStream* source)

This doesn't seem to make sense on the factory. If anything the SVGPathByteStream shoudl have a copy() method which could take a factory pointer if necessary.

> Source/WebCore/svg/SVGPathParserFactory.h:41
> +    // SVGPathByteStream -> SVGPathByteStream
> +    PassOwnPtr<SVGPathByteStream> copySVGPathByteStream(SVGPathByteStream* source);

Why does this go on the factory and not on the bytestream object itself?

[Dirk Schulze]

(In reply to comment #3)
> > Source/WebCore/svg/SVGPathParserFactory.h:41
> > +    // SVGPathByteStream -> SVGPathByteStream
> > +    PassOwnPtr<SVGPathByteStream> copySVGPathByteStream(SVGPathByteStream* source);
> 
> Why does this go on the factory and not on the bytestream object itself?

Hm, sounds reasonable.

[Dirk Schulze]

Created attachment 79977 [details]
Patch

[Dirk Schulze]

(In reply to comment #3)
> (From update of attachment 79875 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79875&action=review
> 
> > Source/WebCore/svg/SVGAnimateElement.cpp:143
> > +            SVGPathParserFactory* factory = SVGPathParserFactory::self();
> 
> I'm not familiar with this self() pattern.  Do we use this other places in WebCore?  I assume you're vending a shared instance here, but I thought we had other naming patterns for such.
Yes this was the intention, dodn't know about a naming schema in WebKit for factories. :-/
The call is used in various places, like SVGPathElement, SVGGlyph or SVGPathSegList.

> 
> > Source/WebCore/svg/SVGPathParserFactory.cpp:129
> > +PassOwnPtr<SVGPathByteStream> SVGPathParserFactory::copySVGPathByteStream(SVGPathByteStream* source)
> 
> This doesn't seem to make sense on the factory. If anything the SVGPathByteStream shoudl have a copy() method which could take a factory pointer if necessary.
> 
> > Source/WebCore/svg/SVGPathParserFactory.h:41
> > +    // SVGPathByteStream -> SVGPathByteStream
> > +    PassOwnPtr<SVGPathByteStream> copySVGPathByteStream(SVGPathByteStream* source);
> 
> Why does this go on the factory and not on the bytestream object itself?
This is fixed in the last patch.

[Nikolas Zimmermann]

Comment on attachment 79977 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79977&action=review

Looks great, r=me with two comments:

> Source/WebCore/svg/SVGPathByteStream.h:54
> +    PassOwnPtr<SVGPathByteStream> copySVGPathByteStream()

I'd name it copy(), as it's a member of SVGPathByteStream...

> Source/WebCore/svg/SVGPathByteStream.h:58
> +        OwnPtr<SVGPathByteStream> copy = SVGPathByteStream::create();
> +        copy->m_data = m_data;
> +        return copy.release();

PassOwnPtr<SVGPathByteStream> copy()
{
    return SVGPathByteStream::create(m_data);
}

Then add a private SVGPathByteStream constructor, taking a Data& reference:
private:
SVGPathByteStream(Data& data)
    : m_data(data)
{
}

That's much cleaner and avoids a OwnPtr -> PassOwnPtr conversion.

[Dirk Schulze]

(In reply to comment #7)
> (From update of attachment 79977 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79977&action=review
> 
> Looks great, r=me with two comments:
> 
> > Source/WebCore/svg/SVGPathByteStream.h:54
> > +    PassOwnPtr<SVGPathByteStream> copySVGPathByteStream()
> 
> I'd name it copy(), as it's a member of SVGPathByteStream...
> 
> > Source/WebCore/svg/SVGPathByteStream.h:58
> > +        OwnPtr<SVGPathByteStream> copy = SVGPathByteStream::create();
> > +        copy->m_data = m_data;
> > +        return copy.release();
> 
> PassOwnPtr<SVGPathByteStream> copy()
> {
>     return SVGPathByteStream::create(m_data);
> }
> 
> Then add a private SVGPathByteStream constructor, taking a Data& reference:
> private:
> SVGPathByteStream(Data& data)
>     : m_data(data)
> {
> }
> 
> That's much cleaner and avoids a OwnPtr -> PassOwnPtr conversion.

I take

    PassOwnPtr<SVGPathByteStream> copy()
    {
        return adoptPtr(new SVGPathByteStream(m_data));
    }

to avoid a second private create function.

[Dirk Schulze]

Committed r76589: <http://trac.webkit.org/changeset/76589>