Bug 52960

Summary:

REGRESSION: Vertical line metrics incorrect

Product:

WebKit

Reporter:

Nikolas Zimmermann <zimmermann>

Component:

Text

Assignee:

Nikolas Zimmermann <zimmermann>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

krit

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

Bug Blocks:

51456

Attachments:

Description	Flags
Patch	krit: review+

Description Nikolas Zimmermann 2011-01-22 05:31:58 PST

After landing the FontMetrics abstraction from bug 51456, vertical line metrics are incorrect.
There's a hack in SimpleFontDataMac.mm that modifies lineGap/descent for a certain vertical font. That hack now influences the lineSpacing, where it shouldn't.

Attaching a patch soon, to restore the old behaviour.

Comment 1 Nikolas Zimmermann 2011-01-22 05:36:54 PST

Created attachment 79844 [details]
Patch

Comment 2 Dirk Schulze 2011-01-22 05:39:41 PST

Comment on attachment 79844 [details]
Patch

r=me

Comment 3 Nikolas Zimmermann 2011-01-22 05:46:57 PST

Landed fix in r76445. Let's see..