Bug 52956

Summary:

[Qt] Support layoutTestController.addURLToRedirect()

Product:

WebKit

Reporter:

Robert Hogan <robert>

Component:

New Bugs

Assignee:

Robert Hogan <robert>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, kling, ossy, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none

Description Robert Hogan 2011-01-22 04:25:42 PST

[Qt] Support layoutTestController.addURLToRedirect()

Comment 1 Robert Hogan 2011-01-22 04:27:04 PST

Created attachment 79842 [details]
Patch

Comment 2 Andreas Kling 2011-01-22 05:01:23 PST

Comment on attachment 79842 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79842&action=review

r=me, one comment.

> Source/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp:1027
> +    QString url = newRequest.url().string();
> +    if (URLsToRedirect.contains(url))
> +        newRequest.setURL(QUrl(URLsToRedirect[url]));

Let's only do this if QWebPagePrivate::drtRun is true.

Comment 3 Robert Hogan 2011-01-22 06:36:36 PST

Created attachment 79845 [details]
Patch

Comment 4 Robert Hogan 2011-01-22 09:28:12 PST

Committed r76451: <http://trac.webkit.org/changeset/76451>