Bug 52935

Summary: [chromium] turn off gyp circular dependency checking and roll chromium deps
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, jamesr, mark
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch jamesr: review+

Description Tony Chang 2011-01-21 15:41:03 PST
[chromium] turn off gyp circular dependency checking and roll chromium deps
Comment 1 Tony Chang 2011-01-21 15:42:09 PST
Created attachment 79805 [details]
Patch
Comment 2 Tony Chang 2011-01-21 15:43:05 PST
Turning off gyp circular dependencies is needed to get us to roll past chromium@72103.
Comment 3 James Robinson 2011-01-21 16:08:34 PST
Are you sure we don't have the circular dependency on mac as well?  Which part of the cycle exists only on mac?

Would it be better to just fix the dependency issue?
Comment 4 James Robinson 2011-01-21 16:08:45 PST
(In reply to comment #3)
> Are you sure we don't have the circular dependency on mac as well?  Which part of the cycle exists only on mac?

exists only on !mac, that is
Comment 5 Tony Chang 2011-01-21 16:17:43 PST
(In reply to comment #4)
> (In reply to comment #3)
> > Are you sure we don't have the circular dependency on mac as well?  Which part of the cycle exists only on mac?
> 
> exists only on !mac, that is

Yes, if it existed on mac, gyp_chromium would have failed.  The dependency is here in a *nix only section:
http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=skia/skia.gyp;h=4c51e8aed406af1293e4168899f65d4755fdc815;hb=HEAD#l714

I've notified the original authors (thakis and reed) of the circular dependency and I think they're going to fix it.  They'll have to fix it if we need this on mac.
Comment 6 Tony Chang 2011-01-21 16:18:35 PST
Here's the same logic in gyp_chromium that would fail for the same reason:
http://git.chromium.org/gitweb/?p=chromium.git;a=blob;f=build/gyp_chromium;h=21717705f30340011f5128ff3f7439955812d8ea;hb=HEAD#l107
Comment 7 James Robinson 2011-01-21 16:53:01 PST
Comment on attachment 79805 [details]
Patch

T.T
Comment 8 Tony Chang 2011-01-24 09:37:56 PST
Committed r76527: <http://trac.webkit.org/changeset/76527>