| Summary: | WebKit2: Need API to stop loading a WKFrame | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brian Weinstein <bweinstein> | ||||
| Component: | WebKit2 | Assignee: | Brian Weinstein <bweinstein> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | andersca, sam | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | PC | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Brian Weinstein
2011-01-21 14:29:33 PST
Created attachment 79794 [details]
[PATCH] Fix
Comment on attachment 79794 [details] [PATCH] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=79794&action=review > Source/WebKit2/UIProcess/WebFrameProxy.cpp:90 > + m_page->process()->send(Messages::WebPage::StopLoadingFrame(m_frameID), m_page->pageID()); It looks like this is the first message that WebFrameProxy will be sending. You should check with Sam or Anders that this is the right place to send the message from. (In reply to comment #2) > (From update of attachment 79794 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79794&action=review > > > Source/WebKit2/UIProcess/WebFrameProxy.cpp:90 > > + m_page->process()->send(Messages::WebPage::StopLoadingFrame(m_frameID), m_page->pageID()); > > It looks like this is the first message that WebFrameProxy will be sending. You should check with Sam or Anders that this is the right place to send the message from. Anders told me this was the right way to do it - I will double check to confirm that this is correct. Thanks for the review! |