Summary: | reduce number of FrameLoaderClient::didChangeScrollOffset calls | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Tony Chang <tony> | ||||
Component: | New Bugs | Assignee: | Tony Chang <tony> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | sam | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Tony Chang
2011-01-21 13:41:19 PST
Created attachment 79786 [details]
Patch
In particular, it seems like the code that was around lines 550-560 here: http://trac.webkit.org/changeset/76291/trunk/Source/WebCore/platform/ScrollView.cpp got lost in r76291. This results in lots of extra calls to FrameLoaderClient::didChangeScrollOffset. It turns out that chromium is the only port that implements this method (so that session restore can remember the page offset), so it's hard to test using DRT. Comment on attachment 79786 [details]
Patch
Thanks for catching this.
r+
Committed r76395: <http://trac.webkit.org/changeset/76395> |