Bug 52915

Summary: reduce number of FrameLoaderClient::didChangeScrollOffset calls
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Description Tony Chang 2011-01-21 13:41:19 PST
reduce number of FrameLoaderClient::didChangeScrollOffset calls
Comment 1 Tony Chang 2011-01-21 14:00:18 PST
Created attachment 79786 [details]
Patch
Comment 2 Tony Chang 2011-01-21 14:02:42 PST
In particular, it seems like the code that was around lines 550-560 here:
http://trac.webkit.org/changeset/76291/trunk/Source/WebCore/platform/ScrollView.cpp

got lost in r76291.  This results in lots of extra calls to FrameLoaderClient::didChangeScrollOffset.  It turns out that chromium is the only port that implements this method (so that session restore can remember the page offset), so it's hard to test using DRT.
Comment 3 Sam Weinig 2011-01-21 14:21:20 PST
Comment on attachment 79786 [details]
Patch

Thanks for catching this.

r+
Comment 4 Tony Chang 2011-01-21 14:32:27 PST
Committed r76395: <http://trac.webkit.org/changeset/76395>