Bug 52912

Summary: [chromium] Get rid of temporary ifdefs
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: New BugsAssignee: John Abd-El-Malek <jam>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, jamesr, tony, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch eric: review+

Description John Abd-El-Malek 2011-01-21 12:18:42 PST 
[chromium] Get rid of temporary ifdefs
Comment 1 John Abd-El-Malek 2011-01-21 12:44:43 PST 
Created attachment 79777 [details]
Patch
Comment 2 Tony Gentilcore 2011-01-21 12:55:15 PST 
What revision added it to Chromium, does it need to be rolled into Source/WebKit/chromium/DEPS?
Comment 3 John Abd-El-Malek 2011-01-21 13:01:02 PST 
it was added a while ago, but the last patch to remove the need for it is 72181.  I'll updated DEPS now (I was going to wait to see if cr-linux passed, but it'll probably fail so no point in waiting).
Comment 4 John Abd-El-Malek 2011-01-21 13:26:35 PST 
Created attachment 79780 [details]
Patch
Comment 5 Tony Gentilcore 2011-01-21 13:28:34 PST 
Looks good, but lets wait for the bot to go green.
Comment 6 WebKit Review Bot 2011-01-21 13:34:40 PST 
Attachment 79780 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7625236
Comment 7 John Abd-El-Malek 2011-01-21 13:37:38 PST 
(In reply to comment #6)
> Attachment 79780 [details] did not build on chromium:
> Build output: http://queues.webkit.org/results/7625236

hmm, the error message is not clear.  Is this one of the cases where by rolling DEPS I have to add another line to it?
Comment 8 Tony Chang 2011-01-21 14:22:05 PST 
(In reply to comment #7)
> (In reply to comment #6)
> > Attachment 79780 [details] [details] did not build on chromium:
> > Build output: http://queues.webkit.org/results/7625236
> 
> hmm, the error message is not clear.  Is this one of the cases where by rolling DEPS I have to add another line to it?

This seems like a real gyp error.  Let me try to repro locally.
Comment 9 Tony Chang 2011-01-21 15:43:34 PST 
I have a patch to roll DEPS here: https://bugs.webkit.org/show_bug.cgi?id=52935
Comment 10 John Abd-El-Malek 2011-01-21 15:48:34 PST 
(In reply to comment #9)
> I have a patch to roll DEPS here: https://bugs.webkit.org/show_bug.cgi?id=52935

Thanks Tony
Comment 11 WebKit Review Bot 2011-01-21 17:19:33 PST 
Attachment 79780 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/7493279
Comment 12 Eric Seidel (no email) 2011-01-22 15:09:14 PST 
Comment on attachment 79780 [details]
Patch

rs=me.
Comment 13 Stephen Chenney 2013-04-09 16:10:32 PDT 
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.