Bug 52912

Summary: [chromium] Get rid of temporary ifdefs
Product: WebKit Reporter: John Abd-El-Malek <jam>
Component: New BugsAssignee: John Abd-El-Malek <jam>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, jamesr, tony, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch eric: review+

John Abd-El-Malek
Reported 2011-01-21 12:18:42 PST
[chromium] Get rid of temporary ifdefs
Attachments
Patch (1.54 KB, patch)
2011-01-21 12:44 PST, John Abd-El-Malek 		no flags
DetailsFormatted DiffDiff
Patch (1.88 KB, patch)
2011-01-21 13:26 PST, John Abd-El-Malek 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
John Abd-El-Malek
Comment 1 2011-01-21 12:44:43 PST
Created attachment 79777 [details] Patch
Tony Gentilcore
Comment 2 2011-01-21 12:55:15 PST
What revision added it to Chromium, does it need to be rolled into Source/WebKit/chromium/DEPS?
John Abd-El-Malek
Comment 3 2011-01-21 13:01:02 PST
it was added a while ago, but the last patch to remove the need for it is 72181. I'll updated DEPS now (I was going to wait to see if cr-linux passed, but it'll probably fail so no point in waiting).
John Abd-El-Malek
Comment 4 2011-01-21 13:26:35 PST
Created attachment 79780 [details] Patch
Tony Gentilcore
Comment 5 2011-01-21 13:28:34 PST
Looks good, but lets wait for the bot to go green.
WebKit Review Bot
Comment 6 2011-01-21 13:34:40 PST
Attachment 79780 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7625236
John Abd-El-Malek
Comment 7 2011-01-21 13:37:38 PST
(In reply to comment #6) > Attachment 79780 [details] did not build on chromium: > Build output: http://queues.webkit.org/results/7625236 hmm, the error message is not clear. Is this one of the cases where by rolling DEPS I have to add another line to it?
Tony Chang
Comment 8 2011-01-21 14:22:05 PST
(In reply to comment #7) > (In reply to comment #6) > > Attachment 79780 [details] [details] did not build on chromium: > > Build output: http://queues.webkit.org/results/7625236 > > hmm, the error message is not clear. Is this one of the cases where by rolling DEPS I have to add another line to it? This seems like a real gyp error. Let me try to repro locally.
Tony Chang
Comment 9 2011-01-21 15:43:34 PST
I have a patch to roll DEPS here: https://bugs.webkit.org/show_bug.cgi?id=52935
John Abd-El-Malek
Comment 10 2011-01-21 15:48:34 PST
(In reply to comment #9) > I have a patch to roll DEPS here: https://bugs.webkit.org/show_bug.cgi?id=52935 Thanks Tony
WebKit Review Bot
Comment 11 2011-01-21 17:19:33 PST
Attachment 79780 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7493279
Eric Seidel (no email)
Comment 12 2011-01-22 15:09:14 PST
Comment on attachment 79780 [details] Patch rs=me.
Stephen Chenney
Comment 13 2013-04-09 16:10:32 PDT
LayoutTest failures for Chromium are being marked WontFix. The Bug is still accessible and referenced from TestExpectations.
Note You need to log in before you can comment on or make changes to this bug.