Bug 52898

Summary: WKCACFLayerRenderer sounds like a render object, but isn't
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cmarrin, eric, simon.fraser, webkit.review.bot
Priority: P2 Keywords: PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Bug Depends on: 52894    
Bug Blocks: 52852    
Attachments:
Description Flags
Rename WKCACFLayerRenderer[Client] to CACFLayerView[Client]
none
Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client] simon.fraser: review+

Description Adam Roben (:aroben) 2011-01-21 08:08:45 PST
WKCACFLayerRenderer sounds like a render object, but isn't. We should rename it!
Comment 1 Adam Roben (:aroben) 2011-01-21 08:14:08 PST
Created attachment 79741 [details]
Rename WKCACFLayerRenderer[Client] to CACFLayerView[Client]
Comment 2 Simon Fraser (smfr) 2011-01-21 08:56:20 PST
Hm, 'view' sounds like something that can be put into a hierarchy (even if we know it to be similar to CAView).
Comment 3 Adam Roben (:aroben) 2011-01-21 09:06:02 PST
(In reply to comment #2)
> Hm, 'view' sounds like something that can be put into a hierarchy (even if we know it to be similar to CAView).

Any suggestions?
Comment 4 Simon Fraser (smfr) 2011-01-21 10:00:53 PST
What is the role of this class when we're using a CAView on Windows?
Comment 5 Adam Roben (:aroben) 2011-01-21 10:23:00 PST
(In reply to comment #4)
> What is the role of this class when we're using a CAView on Windows?

This class owns the PlatformCALayer tree, and knows about WebCore concepts like flushing pending layer changes. It will use CAView just for the purpose of actually rendering those changes to the screen.
Comment 6 Adam Roben (:aroben) 2011-01-21 10:23:22 PST
Comment on attachment 79741 [details]
Rename WKCACFLayerRenderer[Client] to CACFLayerView[Client]

I talked with Simon and John Sullivan about this, and came up with the name CACFLayerTreeHost. I'll do the rename and post a new patch.
Comment 7 Chris Marrin 2011-01-21 11:04:58 PST
(In reply to comment #3)
> (In reply to comment #2)
> > Hm, 'view' sounds like something that can be put into a hierarchy (even if we know it to be similar to CAView).
> 
> Any suggestions?

We could make it a peer of PlatformCALayer and friends. How about PlatformCACompositor. It would have a .h file and then PlatformCACompositorWin.cpp for the Windows implementation. We wouldn't have a Mac version, but that's ok. It might be useful for other platforms in the future.

I know we already have RenderLayerCompositor, but we're really running out of concepts here! And this class would be more of a compositor than RenderLayerCompositor. So it should win :-)
Comment 8 Adam Roben (:aroben) 2011-01-21 11:06:56 PST
Created attachment 79762 [details]
Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]
Comment 9 Adam Roben (:aroben) 2011-01-21 11:36:24 PST
Committed r76370: <http://trac.webkit.org/changeset/76370>
Comment 10 WebKit Review Bot 2011-01-21 11:47:28 PST
http://trac.webkit.org/changeset/76370 might have broken Leopard Intel Debug (Build)