| Summary: | WKCACFLayerRenderer sounds like a render object, but isn't | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | abarth, cmarrin, eric, simon.fraser, webkit.review.bot | ||||||
| Priority: | P2 | Keywords: | PlatformOnly | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | Windows XP | ||||||||
| Bug Depends on: | 52894 | ||||||||
| Bug Blocks: | 52852 | ||||||||
| Attachments: |
|
||||||||
|
Description
Adam Roben (:aroben)
2011-01-21 08:08:45 PST
Created attachment 79741 [details]
Rename WKCACFLayerRenderer[Client] to CACFLayerView[Client]
Hm, 'view' sounds like something that can be put into a hierarchy (even if we know it to be similar to CAView). (In reply to comment #2) > Hm, 'view' sounds like something that can be put into a hierarchy (even if we know it to be similar to CAView). Any suggestions? What is the role of this class when we're using a CAView on Windows? (In reply to comment #4) > What is the role of this class when we're using a CAView on Windows? This class owns the PlatformCALayer tree, and knows about WebCore concepts like flushing pending layer changes. It will use CAView just for the purpose of actually rendering those changes to the screen. Comment on attachment 79741 [details]
Rename WKCACFLayerRenderer[Client] to CACFLayerView[Client]
I talked with Simon and John Sullivan about this, and came up with the name CACFLayerTreeHost. I'll do the rename and post a new patch.
(In reply to comment #3) > (In reply to comment #2) > > Hm, 'view' sounds like something that can be put into a hierarchy (even if we know it to be similar to CAView). > > Any suggestions? We could make it a peer of PlatformCALayer and friends. How about PlatformCACompositor. It would have a .h file and then PlatformCACompositorWin.cpp for the Windows implementation. We wouldn't have a Mac version, but that's ok. It might be useful for other platforms in the future. I know we already have RenderLayerCompositor, but we're really running out of concepts here! And this class would be more of a compositor than RenderLayerCompositor. So it should win :-) Created attachment 79762 [details]
Rename WKCACFLayerRenderer[Client] to CACFLayerTreeHost[Client]
Committed r76370: <http://trac.webkit.org/changeset/76370> http://trac.webkit.org/changeset/76370 might have broken Leopard Intel Debug (Build) |