Bug 52874

Summary: Web Inspector: move sticky breakpoints management from InspectorController to InspectorBrowserDebuggerAgent
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
pfeldman: review-
Patch.
none
Fix style. pfeldman: review+

Description Pavel Podivilov 2011-01-21 02:02:00 PST 
Both InspectorBrowserDebuggerAgent and InspectorDebuggerAgent should manage sticky breakpoints by themselves using InspectorState object.
In this patch, sticky breakpoints management moved from InspectorController to InspectorBrowserDebuggerAgent. Patch for InspectorDebuggerAgent will follow.
Comment 1 Pavel Podivilov 2011-01-21 02:02:40 PST 
Created attachment 79711 [details]
Patch.
Comment 2 WebKit Review Bot 2011-01-21 02:05:40 PST 
Attachment 79711 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:62:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:65:  The parameter name "breakpoints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Pavel Feldman 2011-01-21 02:14:52 PST 
Comment on attachment 79711 [details]
Patch.

I don't see why this is needed.
Comment 4 Pavel Podivilov 2011-01-21 02:52:08 PST 
Created attachment 79717 [details]
Patch.

ChangeLog updated with explanation and link to bug 52879.
Comment 5 WebKit Review Bot 2011-01-21 02:53:30 PST 
Attachment 79717 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/inspector/InspectorController.h:248:  The parameter name "breakpoints" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h:62:  The parameter name "url" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Pavel Podivilov 2011-01-21 02:54:51 PST 
Created attachment 79718 [details]
Fix style.
Comment 7 Pavel Podivilov 2011-01-21 08:09:13 PST 
Committed r76348: <http://trac.webkit.org/changeset/76348>