Bug 52854

Summary: nrwt: fix generated output links in results.html
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tony: review+

Description Dirk Pranke 2011-01-20 16:56:56 PST
nrwt: fix generated output links in results.html
Comment 1 Dirk Pranke 2011-01-20 16:58:49 PST
Created attachment 79667 [details]
Patch
Comment 2 Tony Chang 2011-01-20 17:00:49 PST
Comment on attachment 79667 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79667&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98
> +        self.assertEquals(actual_filename,
> +                          "fast/html/article-element-actual.txt")

Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it.
Comment 3 Dirk Pranke 2011-01-20 17:01:58 PST
(In reply to comment #2)
> (From update of attachment 79667 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79667&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:98
> > +        self.assertEquals(actual_filename,
> > +                          "fast/html/article-element-actual.txt")
> 
> Nit: doesn't seem worth wrapping here since you didn't wrap in the line preceding it.

fair enough. Old habits die hard.
Comment 4 Dirk Pranke 2011-01-20 17:06:57 PST
Committed r76311: <http://trac.webkit.org/changeset/76311>