Bug 52851
| Summary: | check-webkit-style should catch use of #import in non-Mac-only files | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jon Honeycutt <jhoneycutt> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | cmarcelo, levin |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | OS X 10.5 | ||
Jon Honeycutt
It would be nice if the style checker could catch use of #import on files that will be built on platforms other than the Mac to prevent build errors like <http://trac.webkit.org/changeset/75981>.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Levin
I don't know what this check would be.
Is the check
if file extension == 'cpp' and file has '#import', then print 'Don't do #import. This is a C++ file.'
?