Bug 52834

Summary: handle cases where PrettyPatch.rb doesn't linkify filenames
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, eric, mihaip
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+

Description Ojan Vafai 2011-01-20 12:46:43 PST 
handle cases where PrettyPatch.rb doesn't linkify filenames
Comment 1 Ojan Vafai 2011-01-20 12:47:06 PST 
Created attachment 79638 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-20 13:39:13 PST 
Comment on attachment 79638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79638&action=review

I think this is really an aroben patch to review.

> Websites/bugs.webkit.org/code-review.js:343
> +        file_link.target = "_blank";
> +        file_link.href += url_hash;
> +        diff_links.append(tracLinks(file_name, url_hash));

two space indent?
Comment 3 Ojan Vafai 2011-01-20 13:43:12 PST 
Comment on attachment 79638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79638&action=review

>> Websites/bugs.webkit.org/code-review.js:343
>> +        diff_links.append(tracLinks(file_name, url_hash));
> 
> two space indent?

Following the style of the file. Eventually we should make this file follow something closer to standard WebKit style.
Comment 4 Adam Barth 2011-01-20 13:51:52 PST 
jQuery in four-space indent is painful, which is why the file uses two-space indent.
Comment 5 Ojan Vafai 2011-01-20 16:05:03 PST 
Committed r76302: <http://trac.webkit.org/changeset/76302>