Bug 52814

Summary: REGRESSION(r76177): All JavaScriptCore tests fail on ARM
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Blocker CC: commit-queue, galpeter, ggaren, koivisto, loki, oliver, zherczeg
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 52622    
Attachments:
Description Flags
proposed fix none

Description Csaba Osztrogonác 2011-01-20 07:26:22 PST 
http://trac.webkit.org/changeset/76177 made all jsc tests fail on ARM

Gabor or Zoltan, could you check it, please?
Comment 1 Peter Gal 2011-01-21 11:37:50 PST 
Created attachment 79767 [details]
proposed fix

I'm not an OwnPtr expert, but shouldn't we need to get the approximateByteSize before releasing the OwnPtr?

Tested on an ARM build, with run-sunspider and run-javascriptcore-tests all runs ok.
Comment 2 Darin Adler 2011-01-21 11:45:47 PST 
Comment on attachment 79767 [details]
proposed fix

Perfect. Great fix. This depends on the compiler’s order of evaluation for arguments, so could behave differently for different compilers.
Comment 3 WebKit Commit Bot 2011-01-21 12:01:19 PST 
Comment on attachment 79767 [details]
proposed fix

Clearing flags on attachment: 79767

Committed r76376: <http://trac.webkit.org/changeset/76376>
Comment 4 WebKit Commit Bot 2011-01-21 12:01:24 PST 
All reviewed patches have been landed.  Closing bug.
Comment 5 Antti Koivisto 2011-01-22 03:25:22 PST 
Good catch. Thanks for fixing this.