Bug 52802

Summary: SVG Pattern doesn't take preserveAspectRatio of references Pattern
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Testcase: Should see a perfect smiley
none
Patch rwlbuis: review+

Description Dirk Schulze 2011-01-20 05:09:29 PST
SVG Pattern does not take the preserveAspectRatio of a references Pattern (references by xlink:href). Need to add a test later. Just opening the bug for now.
Comment 1 Dirk Schulze 2011-01-20 10:26:41 PST
Created attachment 79613 [details]
Testcase: Should see a perfect smiley

You should see a perfect smiley, if the pattern uses the preserveAspectRatio of the referenced pattern.
Comment 2 Dirk Schulze 2011-01-20 12:41:52 PST
Created attachment 79637 [details]
Patch
Comment 3 Rob Buis 2011-01-20 13:13:54 PST
Comment on attachment 79637 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79637&action=review

Code and test look great, just tiny nitpicks, so r+ from me.

> Source/WebCore/ChangeLog:11
> +

Tiny nitpick, the wording could be better, could you rephrase a bit, "Modified PatternAttributes" is terse, and I don't think you should
put a comma after it for instance.

> LayoutTests/ChangeLog:9
> +

Better: Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.

> LayoutTests/svg/custom/pattern-referencing-preserve-aspect-ratio.svg:4
> +        x="-20" y="0" width="100" height="80" viewBox="0 0 20 40">

One space character too much in there :)

> LayoutTests/svg/custom/pattern-referencing-preserve-aspect-ratio.svg:17
> +</svg>

Indentation is not completely consistent.
Comment 4 Dirk Schulze 2011-01-20 13:27:23 PST
Committed r76274: <http://trac.webkit.org/changeset/76274>