Bug 52756

Summary: nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, mihai, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 52754    
Bug Blocks:    
Attachments:
Description Flags
Patch eric: review+

Description Dirk Pranke 2011-01-19 15:29:28 PST
nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
Comment 1 Dirk Pranke 2011-01-19 15:31:45 PST
Created attachment 79502 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-01-20 03:10:04 PST
Comment on attachment 79502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79502&action=review

> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py:126
> -        return os.path.splitext(filename)[0] + modifier
> +        # FIXME: technically this breaks if files don't use ".ext" to indicate
> +        # the extension, but passing in a Filesystem object here is a huge
> +        # hassle.
> +        return filename[filename.rfind('.')] + modifier

I might have just left this using os.path.splitext with a FIXME about using filesystem instead.

> Tools/Scripts/webkitpy/layout_tests/test_types/text_diff.py:-36
> -from __future__ import with_statement

We're sure this isn't needed?
Comment 3 Eric Seidel (no email) 2011-01-20 03:10:28 PST
Comment on attachment 79502 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79502&action=review

>> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py:126
>> +        return filename[filename.rfind('.')] + modifier
> 
> I might have just left this using os.path.splitext with a FIXME about using filesystem instead.

Does this need testing?
Comment 4 Dirk Pranke 2011-01-20 15:05:39 PST
Committed r76288: <http://trac.webkit.org/changeset/76288>
Comment 5 Dirk Pranke 2011-01-20 15:06:14 PST
In reply to comment #2)
> (From update of attachment 79502 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79502&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py:126
> > -        return os.path.splitext(filename)[0] + modifier
> > +        # FIXME: technically this breaks if files don't use ".ext" to indicate
> > +        # the extension, but passing in a Filesystem object here is a huge
> > +        # hassle.
> > +        return filename[filename.rfind('.')] + modifier
> 
> I might have just left this using os.path.splitext with a FIXME about using filesystem instead.
> 

I felt it was better to not have any reference to os.path at all. 

> > Tools/Scripts/webkitpy/layout_tests/test_types/text_diff.py:-36
> > -from __future__ import with_statement
> 
> We're sure this isn't needed?

Yes. There are no "with" statements in the file.
Comment 6 Dirk Pranke 2011-01-20 15:06:28 PST
(In reply to comment #3)
> (From update of attachment 79502 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79502&action=review
> 
> >> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py:126
> >> +        return filename[filename.rfind('.')] + modifier
> > 
> > I might have just left this using os.path.splitext with a FIXME about using filesystem instead.
> 
> Does this need testing?

It is covered by the existing tests.
Comment 7 Dirk Pranke 2011-01-20 16:58:43 PST
(In reply to comment #6)
> (In reply to comment #3)
> > (From update of attachment 79502 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=79502&action=review
> > 
> > >> Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py:126
> > >> +        return filename[filename.rfind('.')] + modifier
> > > 
> > > I might have just left this using os.path.splitext with a FIXME about using filesystem instead.
> > 
> > Does this need testing?
> 
> It is covered by the existing tests.

Or so I thought :( . See bug 52854.