| Summary: | Chromium builders don't delete unversioned directories when DEPS change | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Barth <abarth> | ||||
| Component: | New Bugs | Assignee: | Adam Barth <abarth> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Adam Barth
2011-01-19 14:24:31 PST
Created attachment 79483 [details]
Patch
Comment on attachment 79483 [details]
Patch
I'm not 100% convinced we should just be piggy backing off of --force here. It could result in losing work if a directory moves out from under you. Maybe that's rare enough and since the user already passed in a flag that it's not a big deal?
Comment on attachment 79483 [details]
Patch
I guess it's ok, but if someone loses data, I'm going to direct them to you :)
IMHO, if you're passing the --force flag, you shouldn't be surprised if something bad happens, but maybe that's just because I've been abused by git for too long. :) (In reply to comment #4) > IMHO, if you're passing the --force flag, you shouldn't be surprised if something bad happens, but maybe that's just because I've been abused by git for too long. :) I agree, but it's weird to have different semantics for --force depending on whether you're in chromium or webkit. Comment on attachment 79483 [details]
Patch
Ok. I think I can stand behind update-webkit-chromium not being the same as gclient sync as well as --force leading to dataloss. We'll see how I feel when someone is sad later. :(
Comment on attachment 79483 [details] Patch Clearing flags on attachment: 79483 Committed r76222: <http://trac.webkit.org/changeset/76222> All reviewed patches have been landed. Closing bug. |