Summary: | Web Inspector: extract presentation code from debugger model | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Podivilov <podivilov> | ||||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Podivilov <podivilov> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Pavel Podivilov
2011-01-19 07:56:27 PST
Created attachment 79427 [details]
Patch.
Comment on attachment 79427 [details] Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=79427&action=review This does not look like "move" - too much new code. Could you split this change into refactoring + new code? > Source/WebCore/ChangeLog:5 > + Move breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane. Web Inspector prefix please. Created attachment 79560 [details]
Fix changelog message.
Committed r76239: <http://trac.webkit.org/changeset/76239> http://trac.webkit.org/changeset/76239 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/open-async-overload.html |