Bug 52723

Summary: Web Inspector: extract presentation code from debugger model
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
pfeldman: review-
Fix changelog message. yurys: review+

Description Pavel Podivilov 2011-01-19 07:56:27 PST
Move breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.
Comment 1 Pavel Podivilov 2011-01-19 07:57:11 PST
Created attachment 79427 [details]
Patch.
Comment 2 Pavel Feldman 2011-01-19 11:29:57 PST
Comment on attachment 79427 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=79427&action=review

This does not look like "move" - too much new code. Could you split this change into refactoring + new code?

> Source/WebCore/ChangeLog:5
> +        Move breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.

Web Inspector prefix please.
Comment 3 Pavel Podivilov 2011-01-20 00:28:06 PST
Created attachment 79560 [details]
Fix changelog message.
Comment 4 Pavel Podivilov 2011-01-20 06:47:33 PST
Committed r76239: <http://trac.webkit.org/changeset/76239>
Comment 5 WebKit Review Bot 2011-01-20 07:20:17 PST
http://trac.webkit.org/changeset/76239 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/xmlhttprequest/open-async-overload.html