Bug 52723 - Web Inspector: extract presentation code from debugger model
Summary: Web Inspector: extract presentation code from debugger model
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-19 07:56 PST by Pavel Podivilov
Modified: 2011-01-20 07:20 PST (History)
13 users (show)

See Also:


Attachments
Patch. (19.33 KB, patch)
2011-01-19 07:57 PST, Pavel Podivilov
pfeldman: review-
Details | Formatted Diff | Diff
Fix changelog message. (19.46 KB, patch)
2011-01-20 00:28 PST, Pavel Podivilov
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-01-19 07:56:27 PST
Move breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.
Comment 1 Pavel Podivilov 2011-01-19 07:57:11 PST
Created attachment 79427 [details]
Patch.
Comment 2 Pavel Feldman 2011-01-19 11:29:57 PST
Comment on attachment 79427 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=79427&action=review

This does not look like "move" - too much new code. Could you split this change into refactoring + new code?

> Source/WebCore/ChangeLog:5
> +        Move breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.

Web Inspector prefix please.
Comment 3 Pavel Podivilov 2011-01-20 00:28:06 PST
Created attachment 79560 [details]
Fix changelog message.
Comment 4 Pavel Podivilov 2011-01-20 06:47:33 PST
Committed r76239: <http://trac.webkit.org/changeset/76239>
Comment 5 WebKit Review Bot 2011-01-20 07:20:17 PST
http://trac.webkit.org/changeset/76239 might have broken SnowLeopard Intel Release (Tests)
The following tests are not passing:
http/tests/xmlhttprequest/open-async-overload.html