WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
52723
Web Inspector: extract presentation code from debugger model
https://bugs.webkit.org/show_bug.cgi?id=52723
Summary
Web Inspector: extract presentation code from debugger model
Pavel Podivilov
Reported
2011-01-19 07:56:27 PST
Move breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.
Attachments
Patch.
(19.33 KB, patch)
2011-01-19 07:57 PST
,
Pavel Podivilov
pfeldman
: review-
Details
Formatted Diff
Diff
Fix changelog message.
(19.46 KB, patch)
2011-01-20 00:28 PST
,
Pavel Podivilov
yurys
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Pavel Podivilov
Comment 1
2011-01-19 07:57:11 PST
Created
attachment 79427
[details]
Patch.
Pavel Feldman
Comment 2
2011-01-19 11:29:57 PST
Comment on
attachment 79427
[details]
Patch. View in context:
https://bugs.webkit.org/attachment.cgi?id=79427&action=review
This does not look like "move" - too much new code. Could you split this change into refactoring + new code?
> Source/WebCore/ChangeLog:5 > + Move breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.
Web Inspector prefix please.
Pavel Podivilov
Comment 3
2011-01-20 00:28:06 PST
Created
attachment 79560
[details]
Fix changelog message.
Pavel Podivilov
Comment 4
2011-01-20 06:47:33 PST
Committed
r76239
: <
http://trac.webkit.org/changeset/76239
>
WebKit Review Bot
Comment 5
2011-01-20 07:20:17 PST
http://trac.webkit.org/changeset/76239
might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/xmlhttprequest/open-async-overload.html
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug