Bug 52694

Summary: new-run-webkit-tests: add a --build-directory command line argument
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: chase, eric, mihaip, ojan, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch tony: review+

Dirk Pranke
Reported 2011-01-18 18:33:00 PST
new-run-webkit-tests: add a --build-directory command line argument
Attachments
Patch (4.50 KB, patch)
2011-01-18 18:35 PST, Dirk Pranke 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2011-01-18 18:35:01 PST
Created attachment 79379 [details] Patch
Tony Chang
Comment 2 2011-01-18 19:54:07 PST
Comment on attachment 79379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281 > + optparse.make_option("--build-directory", > + help="Absolute path to the directory under which build files are kept (should not include configuration)"), Does it have to be absolute? Won't paths relative to where NRWT is run from work?
Dirk Pranke
Comment 3 2011-01-18 21:09:47 PST
(In reply to comment #2) > (From update of attachment 79379 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281 > > + optparse.make_option("--build-directory", > > + help="Absolute path to the directory under which build files are kept (should not include configuration)"), > > Does it have to be absolute? Won't paths relative to where NRWT is run from work? Yeah, technically relative paths would work, too. I'll fix the comment when I land the patch.
Dirk Pranke
Comment 4 2011-01-18 21:15:20 PST
Committed r76101: <http://trac.webkit.org/changeset/76101>
Note You need to log in before you can comment on or make changes to this bug.