| Summary: | new-run-webkit-tests: add a --build-directory command line argument | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dirk Pranke <dpranke> | ||||
| Component: | New Bugs | Assignee: | Dirk Pranke <dpranke> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | chase, eric, mihaip, ojan, tony | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Dirk Pranke
2011-01-18 18:33:00 PST
Created attachment 79379 [details]
Patch
Comment on attachment 79379 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281 > + optparse.make_option("--build-directory", > + help="Absolute path to the directory under which build files are kept (should not include configuration)"), Does it have to be absolute? Won't paths relative to where NRWT is run from work? (In reply to comment #2) > (From update of attachment 79379 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=79379&action=review > > > Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py:281 > > + optparse.make_option("--build-directory", > > + help="Absolute path to the directory under which build files are kept (should not include configuration)"), > > Does it have to be absolute? Won't paths relative to where NRWT is run from work? Yeah, technically relative paths would work, too. I'll fix the comment when I land the patch. Committed r76101: <http://trac.webkit.org/changeset/76101> |