Bug 52685

Summary: Refactoring: WebKit should have RoundedFloatRect
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: NEW    
Severity: Normal CC: bruno.abinader, eric, simon.fraser, tonikitoo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch none

Hajime Morrita
Reported 2011-01-18 16:56:34 PST
Coined at Bug Bug 51664. As an argument for Path::addRoundedRect(), we could make RoundedFloatRect, which supports implicit conversion from RoundedIntRect.
Attachments
Patch (22.30 KB, patch)
2011-01-19 01:16 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-01-19 01:16:18 PST
Created attachment 79400 [details] Patch
Hajime Morrita
Comment 2 2011-01-19 01:17:37 PST
Hi Antonio, Could you take a look when you have time? We have a new member for rounded rect family.
Antonio Gomes
Comment 3 2011-01-19 06:33:49 PST
Comment on attachment 79400 [details] Patch LGTM. ps: I though the patch had landed already.
Hajime Morrita
Comment 4 2011-01-19 17:38:00 PST
HI Antonio, thank you for taking a look! > > ps: I though the patch had landed already. I'm sorry but I miss the point... Are you saying about Bug 51664?
Simon Fraser (smfr)
Comment 5 2011-01-20 08:35:10 PST
Is it really worth it, for the 4 lines of code that use it?
Hajime Morrita
Comment 6 2011-01-20 17:50:44 PST
> Is it really worth it, for the 4 lines of code that use it? Hmm, good question. I just thought it is symmetrically reasonable.
Eric Seidel (no email)
Comment 7 2011-01-21 02:57:17 PST
Comment on attachment 79400 [details] Patch We could use a template to share code with the Int version. But i agree, this is probably pre-mature optimization to add a class for just 4 lines. :)
Hajime Morrita
Comment 8 2011-01-23 15:37:12 PST
Comment on attachment 79400 [details] Patch Thank you for the feedback. I'm removing r? at this time and will back when the time is ripe :-)
Note You need to log in before you can comment on or make changes to this bug.