Summary: | [chromium] simplify complex text code, fixing a handful of layout tests | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Evan Martin <evan> | ||||
Component: | New Bugs | Assignee: | Evan Martin <evan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | tony | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Evan Martin
2011-01-18 13:50:47 PST
Created attachment 79322 [details]
Patch
With this patch, I can now select text on http://tanzil.net/ with fewer gaps in the highlighting. Comment on attachment 79322 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79322&action=review > Source/WebCore/platform/graphics/chromium/FontLinux.cpp:212 > + // FIXME: this causes us to shape the text twice -- once to compute the width and then again > + // below when actually rendering. Change ComplexTextController to match platform/mac and > + // platform/chromium/win by having it store the shaped runs, so we can reuse the results. This is my only concern with this patch but evan said he would (1) watch the intl page cycler bots for regressions and (2) work on trying to clean this up so we don't have to shave the text twice (perhaps by doing what Windows does). Committed r76137: <http://trac.webkit.org/changeset/76137> |