Summary: | make file expansion use the file at the svn revision the diff was created at | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, aroben, eric, mihaip | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Ojan Vafai
2011-01-18 12:47:48 PST
Created attachment 79310 [details]
Patch
Comment on attachment 79310 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=79310&action=review Looks good though. > Websites/bugs.webkit.org/code-review.js:424 > + var suffix = revision ? '?p=' + revision : ''; suffix seems a bit odd for a name here. You're constructing a query, with a single p= parameter. Committed r76082: <http://trac.webkit.org/changeset/76082> |