Bug 52646

Summary:

Implement NPN_PopUpContextMenu

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2011-01-18 12:01:45 PST

Implement NPN_PopUpContextMenu

Comment 1 Anders Carlsson 2011-01-18 12:05:04 PST

Created attachment 79304 [details]
Patch

Comment 2 Sam Weinig 2011-01-18 12:07:56 PST

Comment on attachment 79304 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=79304&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h:209
> +    NPCocoaEvent *m_currentMouseEvent;

* on the wrong side. Or at least, I think it is, assuming NPCocoaEvent is no an objective-c object.

> Source/WebKit2/WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:492
> +            NPCocoaEvent *previousMouseEvent = m_currentMouseEvent;

* on wrong side.

Comment 3 Anders Carlsson 2011-01-18 12:09:15 PST

Committed r76043: <http://trac.webkit.org/changeset/76043>