Bug 52619

Summary:

Web Inspector: preserve pause on exception state in settings.

Product:

WebKit

Reporter:

Pavel Feldman <pfeldman>

Component:

Web Inspector (Deprecated)

Assignee:

Pavel Feldman <pfeldman>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed change.	yurys: review+

Pavel Feldman

Reported 2011-01-18 04:38:04 PST

Patch to follow.

Attachments
[PATCH] Proposed change. (8.17 KB, patch) 2011-01-18 05:16 PST, Pavel Feldman	yurys: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Pavel Feldman

Comment 1 2011-01-18 05:16:17 PST

Created attachment 79265 [details] [PATCH] Proposed change.

Yury Semikhatsky

Comment 2 2011-01-18 05:22:44 PST

Comment on attachment 79265 [details] [PATCH] Proposed change. View in context: https://bugs.webkit.org/attachment.cgi?id=79265&action=review > Source/WebCore/inspector/front-end/ScriptsPanel.js:393 > + this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionState); Please make sure that this preference is properly cleared in the tests.

Pavel Feldman

Comment 3 2011-01-18 06:20:51 PST

Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/platform/chromium/test_expectations.txt M Source/WebCore/ChangeLog M Source/WebCore/inspector/InspectorController.cpp M Source/WebCore/inspector/InspectorDebuggerAgent.cpp M Source/WebCore/inspector/InspectorDebuggerAgent.h M Source/WebCore/inspector/front-end/ScriptsPanel.js M Source/WebCore/inspector/front-end/Settings.js M Source/WebCore/inspector/front-end/inspector.js Committed r76021

Note You need to log in before you can comment on or make changes to this bug.