Bug 52619

Summary: Web Inspector: preserve pause on exception state in settings.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Description Flags
[PATCH] Proposed change. yurys: review+

Description Pavel Feldman 2011-01-18 04:38:04 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-01-18 05:16:17 PST
Created attachment 79265 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2011-01-18 05:22:44 PST
Comment on attachment 79265 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=79265&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:393
> +        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionState);

Please make sure that this preference is properly cleared in the tests.
Comment 3 Pavel Feldman 2011-01-18 06:20:51 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/platform/chromium/test_expectations.txt
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/InspectorController.cpp
        M       Source/WebCore/inspector/InspectorDebuggerAgent.cpp
        M       Source/WebCore/inspector/InspectorDebuggerAgent.h
        M       Source/WebCore/inspector/front-end/ScriptsPanel.js
        M       Source/WebCore/inspector/front-end/Settings.js
        M       Source/WebCore/inspector/front-end/inspector.js
Committed r76021