Bug 52619 - Web Inspector: preserve pause on exception state in settings.
Summary: Web Inspector: preserve pause on exception state in settings.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
Depends on:
Reported: 2011-01-18 04:38 PST by Pavel Feldman
Modified: 2011-01-18 06:20 PST (History)
10 users (show)

See Also:

[PATCH] Proposed change. (8.17 KB, patch)
2011-01-18 05:16 PST, Pavel Feldman
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-01-18 04:38:04 PST
Patch to follow.
Comment 1 Pavel Feldman 2011-01-18 05:16:17 PST
Created attachment 79265 [details]
[PATCH] Proposed change.
Comment 2 Yury Semikhatsky 2011-01-18 05:22:44 PST
Comment on attachment 79265 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=79265&action=review

> Source/WebCore/inspector/front-end/ScriptsPanel.js:393
> +        this._setPauseOnExceptions(WebInspector.settings.pauseOnExceptionState);

Please make sure that this preference is properly cleared in the tests.
Comment 3 Pavel Feldman 2011-01-18 06:20:51 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       LayoutTests/platform/chromium/test_expectations.txt
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/InspectorController.cpp
        M       Source/WebCore/inspector/InspectorDebuggerAgent.cpp
        M       Source/WebCore/inspector/InspectorDebuggerAgent.h
        M       Source/WebCore/inspector/front-end/ScriptsPanel.js
        M       Source/WebCore/inspector/front-end/Settings.js
        M       Source/WebCore/inspector/front-end/inspector.js
Committed r76021