Bug 52615

Summary: Web Inspector: set breakpoints by line:column
Product: WebKit Reporter: Pavel Podivilov <podivilov>
Component: Web Inspector (Deprecated)Assignee: Pavel Podivilov <podivilov>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch.
none
Patch. yurys: review+

Description Pavel Podivilov 2011-01-18 01:14:47 PST
Web Inspector: set breakpoints by line:column.
Comment 1 Pavel Podivilov 2011-01-18 01:15:41 PST
Created attachment 79251 [details]
Patch.
Comment 2 Pavel Podivilov 2011-01-18 01:28:52 PST
Created attachment 79254 [details]
Patch.
Comment 3 Yury Semikhatsky 2011-01-24 04:36:52 PST
Comment on attachment 79254 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=79254&action=review

Please address the comments before landing.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:153
> +    *actualColumnNumber = 1;

Please file a bug against JSC and add FIXME comment here.

> Source/WebCore/bindings/js/ScriptDebugServer.h:138
> +    typedef HashMap<long, ScriptBreakpoint> ScriptBreakpoints;

ScriptBreakpoints -> LineToScriptBreakpointMap

> Source/WebCore/bindings/js/ScriptDebugServer.h:139
> +    typedef HashMap<intptr_t, ScriptBreakpoints> BreakpointsMap;

BreakpointsMap -> SourceIdToBreakpointsMap, I'd also recommend renaming corresponding fields as m_breakpoints sounds too general.

> Source/WebCore/inspector/InspectorDebuggerAgent.h:100
> +    typedef HashMap<Location, ScriptBreakpoint> ScriptBreakpoints;

ScriptBreakpoints -> LocationToBreakpointMap
Comment 4 Pavel Podivilov 2011-01-24 05:56:28 PST
Committed r76509: <http://trac.webkit.org/changeset/76509>
Comment 5 WebKit Review Bot 2011-01-24 06:10:47 PST
http://trac.webkit.org/changeset/76509 might have broken Leopard Intel Release (Build) and Leopard Intel Debug (Build)