Bug 52615 - Web Inspector: set breakpoints by line:column
Summary: Web Inspector: set breakpoints by line:column
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 01:14 PST by Pavel Podivilov
Modified: 2011-01-24 06:10 PST (History)
13 users (show)

See Also:

Attachments
Patch. (35.82 KB, patch)
2011-01-18 01:15 PST, Pavel Podivilov 		no flags Details | Formatted Diff | Diff
Patch. (36.53 KB, patch)
2011-01-18 01:28 PST, Pavel Podivilov 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-01-18 01:14:47 PST 
Web Inspector: set breakpoints by line:column.
Comment 1 Pavel Podivilov 2011-01-18 01:15:41 PST 
Created attachment 79251 [details]
Patch.
Comment 2 Pavel Podivilov 2011-01-18 01:28:52 PST 
Created attachment 79254 [details]
Patch.
Comment 3 Yury Semikhatsky 2011-01-24 04:36:52 PST 
Comment on attachment 79254 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=79254&action=review

Please address the comments before landing.

> Source/WebCore/bindings/js/ScriptDebugServer.cpp:153
> +    *actualColumnNumber = 1;

Please file a bug against JSC and add FIXME comment here.

> Source/WebCore/bindings/js/ScriptDebugServer.h:138
> +    typedef HashMap<long, ScriptBreakpoint> ScriptBreakpoints;

ScriptBreakpoints -> LineToScriptBreakpointMap

> Source/WebCore/bindings/js/ScriptDebugServer.h:139
> +    typedef HashMap<intptr_t, ScriptBreakpoints> BreakpointsMap;

BreakpointsMap -> SourceIdToBreakpointsMap, I'd also recommend renaming corresponding fields as m_breakpoints sounds too general.

> Source/WebCore/inspector/InspectorDebuggerAgent.h:100
> +    typedef HashMap<Location, ScriptBreakpoint> ScriptBreakpoints;

ScriptBreakpoints -> LocationToBreakpointMap
Comment 4 Pavel Podivilov 2011-01-24 05:56:28 PST 
Committed r76509: <http://trac.webkit.org/changeset/76509>
Comment 5 WebKit Review Bot 2011-01-24 06:10:47 PST 
http://trac.webkit.org/changeset/76509 might have broken Leopard Intel Release (Build) and Leopard Intel Debug (Build)