Bug 52584 – Web Inspector: unify image data source assignment, add image url to the image view properties list.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 79182 [details]
[PATCH] Proposed change.

[Pavel Feldman]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/English.lproj/localizedStrings.js
        M       Source/WebCore/inspector/front-end/ImageView.js
        M       Source/WebCore/inspector/front-end/NetworkPanel.js
        M       Source/WebCore/inspector/front-end/Resource.js
        M       Source/WebCore/inspector/front-end/ResourcesPanel.js
Committed r75952

[Andrey Kosyakov]

Comment on attachment 79182 [details]
[PATCH] Proposed change.

View in context: https://bugs.webkit.org/attachment.cgi?id=79182&action=review

> Source/WebCore/inspector/front-end/NetworkPanel.js:1422
> +            this._resource.populateImageSource(imagePreviewElement);

imagePreviewElement is not defined here. Was this change ever tested?

[Pavel Feldman]

(In reply to comment #3)
> (From update of attachment 79182 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=79182&action=review
> 
> > Source/WebCore/inspector/front-end/NetworkPanel.js:1422
> > +            this._resource.populateImageSource(imagePreviewElement);
> 
> imagePreviewElement is not defined here. Was this change ever tested?

Sorry about that - too many changes today. Fixed in r75964.