Bug 52571

Summary: [Qt] Fixed compilation with QT_NO_GRAPHICSVIEW
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Enhancement CC: benjamin, eric, laszlo.gombos, ossy
Priority: P3 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Fixed compilation with QT_NO_GRAPHICSVIEW benjamin: review-

Description Konstantin Tokarev 2011-01-17 06:20:59 PST 
This patch fixes compilation of QtWebKit when QGraphicsView is disabled in Qt configuration
Comment 1 Konstantin Tokarev 2011-01-17 06:24:55 PST 
Created attachment 79161 [details]
Fixed compilation with QT_NO_GRAPHICSVIEW
Comment 2 Laszlo Gombos 2011-01-17 14:57:47 PST 
This seems like a DUP of bug 49750. 

Konstantin, do you have ACCELERATED_COMPOSITING enabled ?
Comment 3 Konstantin Tokarev 2011-01-18 07:29:09 PST 
>This seems like a DUP of bug 49750

Maybe. 

BTW, trunk still does not compile without this patch. Should I relocate it?

>Konstantin, do you have ACCELERATED_COMPOSITING enabled ?

Yes, it's enabled. However, I don't understand how can I manage it :)
Comment 4 Laszlo Gombos 2011-01-18 07:47:56 PST 
(In reply to comment #3)
> >This seems like a DUP of bug 49750
> 
> Maybe. 
> 
> BTW, trunk still does not compile without this patch. Should I relocate it?
> 
> >Konstantin, do you have ACCELERATED_COMPOSITING enabled ?
> 
> Yes, it's enabled. However, I don't understand how can I manage it :)

Perhaps ACCELERATED_COMPOSITING should not be enabled (and than the stub in GraphicsLayerQt.cpp is not needed).

Can you try the last patch attached to bug 4975 (https://bug-49750-attachments.webkit.org/attachment.cgi?id=79124). If it works I think we think we should mark this bug a DUP of 49750.

The path at bug 49750 disables ACCELERATED_COMPOSITING (unless Texture Mapper is turned on).
Comment 5 Konstantin Tokarev 2011-01-18 09:20:36 PST 
(In reply to comment #4)
> (In reply to comment #3)
> > >This seems like a DUP of bug 49750
> > 
> > Maybe. 
> > 
> > BTW, trunk still does not compile without this patch. Should I relocate it?
> > 
> > >Konstantin, do you have ACCELERATED_COMPOSITING enabled ?
> > 
> > Yes, it's enabled. However, I don't understand how can I manage it :)
> 
> Perhaps ACCELERATED_COMPOSITING should not be enabled (and than the stub in GraphicsLayerQt.cpp is not needed).
> 
> Can you try the last patch attached to bug 4975 (https://bug-49750-attachments.webkit.org/attachment.cgi?id=79124). If it works I think we think we should mark this bug a DUP of 49750.
> 
> The path at bug 49750 disables ACCELERATED_COMPOSITING (unless Texture Mapper is turned on).

I've applied that path. Nevertheless, I get ACCELERATED_COMPOSITING enabled in Platform.h

PLATFORM(QT) && (!defined(QT_NO_GRAPHICSVIEW) || USE(TEXTURE_MAPPER))

In my case, QT_NO_GRAPHICSVIEW is not defined here. Seems like no Qt headers were included
Comment 6 Eric Seidel (no email) 2011-01-24 15:39:49 PST 
Comment on attachment 79161 [details]
Fixed compilation with QT_NO_GRAPHICSVIEW

Seems kinda hacky.  Does this work?
Comment 7 Benjamin Poulain 2011-01-28 18:26:55 PST 
Comment on attachment 79161 [details]
Fixed compilation with QT_NO_GRAPHICSVIEW

Graphic layer is a concept of accelerated compositing. Accelerated compositing rely on QGraphicsView if you do not use texture mapper.

Having accelerated compositing without QGraphicsView and without texture mapper should not be supported IMHO.
Comment 8 Csaba Osztrogonác 2011-10-24 01:03:00 PDT 
Closing bug, based on Benjamin's comment.