| Summary: | <keygen> presents itself as a HTMLSelectElement to script | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dominic Cooney <dominicc> | ||||||||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | abarth, aroben, commit-queue, eric, gustavo, jberlin, ossy, tkent, webkit.review.bot, xan.lopez | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | OS X 10.5 | ||||||||||||
| Bug Depends on: | |||||||||||||
| Bug Blocks: | 51379, 52787 | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Dominic Cooney
2011-01-17 00:20:50 PST
Created attachment 79137 [details]
Patch
Created attachment 79138 [details]
Patch
Syncs to head.
Comment on attachment 79138 [details]
Patch
Looks great.
Comment on attachment 79138 [details] Patch Rejecting attachment 79138 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: dings/gobject/GNUmakefile.am patching file Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp patching file Source/WebCore/bindings/objc/DOM.mm patching file Source/WebCore/html/HTMLKeygenElement.h patching file Source/WebCore/html/HTMLKeygenElement.idl patching file Source/WebCore/html/HTMLTagNames.in patching file Source/WebCore/page/DOMWindow.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/7549177 Attachment 79138 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7515176 Possible conflict and a GTK build error. Please update the patch. Created attachment 79387 [details]
Syncs to head and makes GTK build.
Comment on attachment 79387 [details] Syncs to head and makes GTK build. Rejecting attachment 79387 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-3', 'apply-..." exit_code: 2 Last 500 characters of output: hing file Source/WebCore/bindings/objc/DOM.mm patching file Source/WebCore/html/HTMLKeygenElement.h Hunk #1 FAILED at 32. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/html/HTMLKeygenElement.h.rej patching file Source/WebCore/html/HTMLKeygenElement.idl patching file Source/WebCore/html/HTMLTagNames.in patching file Source/WebCore/page/DOMWindow.idl Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/7600223 Created attachment 79552 [details]
Patch
Comment on attachment 79387 [details] Syncs to head and makes GTK build. View in context: https://bugs.webkit.org/attachment.cgi?id=79387&action=review > Source/WebCore/ChangeLog:13 > + Make <keygen> no longer appear to be a <select> element to script. > + > + The intent is to put <keygen> options into shadow DOM. This change > + takes the first step by hiding the <select> element from > + JavaScript. > + > + Test: fast/dom/HTMLKeygenElement/keygen.html > + > + https://bugs.webkit.org/show_bug.cgi?id=52557 nit: We usually use the following format: <summary> <bug URL> <description> Test: <test names> Comment on attachment 79552 [details] Patch Rejecting attachment 79552 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-sf-cq', 'ap..." exit_code: 2 Last 500 characters of output: ore/bindings/gobject/GNUmakefile.am patching file Source/WebCore/bindings/gobject/WebKitHTMLElementWrapperFactory.cpp patching file Source/WebCore/bindings/objc/DOM.mm patching file Source/WebCore/html/HTMLKeygenElement.h patching file Source/WebCore/html/HTMLKeygenElement.idl patching file Source/WebCore/html/HTMLTagNames.in patching file Source/WebCore/page/DOMWindow.idl Failed to run "[u'/Projects/CommitQueue/Tools/Scripts/svn-apply', u'--reviewer', u'Kent Tamura', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/7544229 Landed manually: http://trac.webkit.org/changeset/76208 http://trac.webkit.org/changeset/76208 might have broken Qt Linux Release The following tests are not passing: fast/dom/Window/window-properties.html fast/dom/Window/window-property-descriptors.html fast/dom/prototype-inheritance.html fast/js/global-constructors.html Why are these results forked for Qt? We should find a way to make that not be the case, otherwise everyone is going to break them all the time. (In reply to comment #12) > Landed manually: http://trac.webkit.org/changeset/76208 I will be adding the Windows-specific results for fast/dom/prototype-inheritance-2.html fast/dom/prototype-inheritance.html fast/dom/Window/window-property-descriptors.html fast/js/global-constructors.html shortly in order to get the bots green. I am not sure why we have windows-specific results for these tests, and I will look into why we do after I get the bots green. (In reply to comment #15) > (In reply to comment #12) > > Landed manually: http://trac.webkit.org/changeset/76208 > > I will be adding the Windows-specific results for > > fast/dom/prototype-inheritance-2.html > fast/dom/prototype-inheritance.html > fast/dom/Window/window-property-descriptors.html > fast/js/global-constructors.html > > shortly in order to get the bots green. I am not sure why we have windows-specific results for these tests, and I will look into why we do after I get the bots green. Adam Roben mentioned that this is probably related to Dashboard regions, which are a Mac-only feature. That would also explain the different results for Qt. Submitted the modified Windows 7 results in http://trac.webkit.org/changeset/76350 |