Summary: | [GTK] Many DOM XHTML tests time out | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, eric, svillar, webkit.review.bot, xan.lopez | ||||
Priority: | P3 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Martin Robinson
2011-01-16 23:08:04 PST
Created attachment 79129 [details]
Patch
Comment on attachment 79129 [details]
Patch
Can't we run the loop with a timeout? Or schedule a timeout event on the loop before we run it? That seems like a more general fix for this problem than this specific exclusion.
(In reply to comment #2) > (From update of attachment 79129 [details]) > Can't we run the loop with a timeout? Or schedule a timeout event on the loop before we run it? That seems like a more general fix for this problem than this specific exclusion. I had considered a solution like this, but the details of the operation of the WebCoreSynchronousLoader are hidden from ResourceHandle::loadResourceSynchronously. Meanwhile, the handle itself "owns" the WebCoreSynchronousLoader (it's the client), so it didn't seem clean to add another relationship. I finally chose this approach because it matches the CF network code. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 79129 [details] [details]) > > Can't we run the loop with a timeout? Or schedule a timeout event on the loop before we run it? That seems like a more general fix for this problem than this specific exclusion. > > I had considered a solution like this, but the details of the operation of the WebCoreSynchronousLoader are hidden from ResourceHandle::loadResourceSynchronously. Meanwhile, the handle itself "owns" the WebCoreSynchronousLoader (it's the client), so it didn't seem clean to add another relationship. I finally chose this approach because it matches the CF network code. By the way, thanks for the review! Comment on attachment 79129 [details] Patch Clearing flags on attachment: 79129 Committed r76555: <http://trac.webkit.org/changeset/76555> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/76555 might have broken GTK Linux 32-bit Release The following tests are not passing: http/tests/xmlhttprequest/simple-cross-origin-denied-events-post.html http/tests/xmlhttprequest/simple-cross-origin-denied-events-sync.html media/unsupported-rtsp.html |