Bug 52551

Summary: AffineTransform::translateRight incorrectly computes a translateLeft.
Product: WebKit Reporter: Shane Stephens <shanestephens>
Component: New BugsAssignee: Shane Stephens <shanestephens>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dino, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 48031    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Description Shane Stephens 2011-01-16 22:09:43 PST
AffineTransform::translateRight incorrectly computes a translateLeft.
Comment 1 Shane Stephens 2011-01-16 22:10:52 PST
Created attachment 79125 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-16 22:12:15 PST
Attachment 79125 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Shane Stephens 2011-01-16 22:22:34 PST
Created attachment 79126 [details]
Patch
Comment 4 Shane Stephens 2011-01-16 22:24:21 PST
The attached patch removes translateRight from AffineTransform and uses standard matrix multiplication where translateRight was previously used.  See http://bugs.webkit.org/show_bug.cgi?id=48031 for more context & discussion.

Please don't commit this patch until 48031 is committed!  Otherwise approximately 40 layout tests will break :)
Comment 5 WebKit Commit Bot 2011-01-31 10:11:23 PST
Comment on attachment 79126 [details]
Patch

Clearing flags on attachment: 79126

Committed r77140: <http://trac.webkit.org/changeset/77140>
Comment 6 WebKit Commit Bot 2011-01-31 10:11:28 PST
All reviewed patches have been landed.  Closing bug.