Bug 52551 - AffineTransform::translateRight incorrectly computes a translateLeft.
Summary: AffineTransform::translateRight incorrectly computes a translateLeft.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Shane Stephens
URL:
Keywords:
Depends on: 48031
Blocks:
  Show dependency tree / graph
 
Reported: 2011-01-16 22:09 PST by Shane Stephens
Modified: 2011-01-31 10:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.64 KB, patch)
2011-01-16 22:10 PST, Shane Stephens 		no flags Details | Formatted Diff | Diff
Patch (7.64 KB, patch)
2011-01-16 22:22 PST, Shane Stephens 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Shane Stephens 2011-01-16 22:09:43 PST 
AffineTransform::translateRight incorrectly computes a translateLeft.
Comment 1 Shane Stephens 2011-01-16 22:10:52 PST 
Created attachment 79125 [details]
Patch
Comment 2 WebKit Review Bot 2011-01-16 22:12:15 PST 
Attachment 79125 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:11:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Shane Stephens 2011-01-16 22:22:34 PST 
Created attachment 79126 [details]
Patch
Comment 4 Shane Stephens 2011-01-16 22:24:21 PST 
The attached patch removes translateRight from AffineTransform and uses standard matrix multiplication where translateRight was previously used.  See http://bugs.webkit.org/show_bug.cgi?id=48031 for more context & discussion.

Please don't commit this patch until 48031 is committed!  Otherwise approximately 40 layout tests will break :)
Comment 5 WebKit Commit Bot 2011-01-31 10:11:23 PST 
Comment on attachment 79126 [details]
Patch

Clearing flags on attachment: 79126

Committed r77140: <http://trac.webkit.org/changeset/77140>
Comment 6 WebKit Commit Bot 2011-01-31 10:11:28 PST 
All reviewed patches have been landed.  Closing bug.