Bug 52532

Summary: Web Inspector: make WebCore use InspectorInstrumentation for instrumentation calls.
Product: WebKit Reporter: Pavel Feldman <pfeldman>
Component: Web Inspector (Deprecated)Assignee: Pavel Feldman <pfeldman>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 52510    
Attachments:
Description Flags
[PATCH] Proposed change
yurys: review-
[PATCH] Review comments addressed. yurys: review+

Pavel Feldman
Reported 2011-01-16 03:20:38 PST
Patch to follow.
Attachments
[PATCH] Proposed change (98.15 KB, patch)
2011-01-16 13:04 PST, Pavel Feldman 		yurys: review-
DetailsFormatted DiffDiff
[PATCH] Review comments addressed. (98.10 KB, patch)
2011-01-17 02:31 PST, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-01-16 13:04:33 PST
Created attachment 79109 [details] [PATCH] Proposed change
Yury Semikhatsky
Comment 2 2011-01-17 02:27:32 PST
Comment on attachment 79109 [details] [PATCH] Proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=79109&action=review > Source/WebCore/inspector/InspectorController.cpp:151 > + InspectorInstrumentation::inspectorControllerCreated(page, this); I'd rather declare a friend function that would get InspectorAgent from Page. > Source/WebCore/inspector/InspectorInstrumentation.h:893 > + return inspectorControllerWithFrontendForPage(static_cast<Document*>(context)->page()); Should return IC even if there is no FE > Source/WebCore/inspector/InspectorInstrumentation.h:915 > + return inspectorControllerForContext(context); Please check that the IC has FE
Pavel Feldman
Comment 3 2011-01-17 02:31:34 PST
Created attachment 79145 [details] [PATCH] Review comments addressed.
Pavel Feldman
Comment 4 2011-01-17 02:45:54 PST
Committing to http://svn.webkit.org/repository/webkit/trunk ... M Source/WebCore/ChangeLog M Source/WebCore/dom/Document.cpp M Source/WebCore/dom/Document.h M Source/WebCore/dom/ScriptExecutionContext.h M Source/WebCore/inspector/InspectorBrowserDebuggerAgent.cpp M Source/WebCore/inspector/InspectorBrowserDebuggerAgent.h M Source/WebCore/inspector/InspectorConsoleAgent.cpp M Source/WebCore/inspector/InspectorConsoleAgent.h M Source/WebCore/inspector/InspectorController.cpp M Source/WebCore/inspector/InspectorController.h M Source/WebCore/inspector/InspectorDOMAgent.h M Source/WebCore/inspector/InspectorDOMStorageAgent.h M Source/WebCore/inspector/InspectorDatabaseAgent.cpp M Source/WebCore/inspector/InspectorDatabaseAgent.h M Source/WebCore/inspector/InspectorFrontendHost.cpp M Source/WebCore/inspector/InspectorFrontendHost.h M Source/WebCore/inspector/InspectorInstrumentation.cpp M Source/WebCore/inspector/InspectorInstrumentation.h M Source/WebCore/inspector/InspectorState.cpp M Source/WebCore/loader/FrameLoader.cpp M Source/WebCore/page/Chrome.cpp M Source/WebCore/page/Console.cpp M Source/WebCore/page/DOMWindow.cpp M Source/WebCore/page/EventHandler.cpp M Source/WebCore/page/Page.cpp M Source/WebCore/storage/Database.cpp M Source/WebCore/workers/AbstractWorker.cpp M Source/WebCore/workers/SharedWorker.cpp M Source/WebCore/workers/Worker.cpp M Source/WebCore/workers/WorkerMessagingProxy.cpp Committed r75932
Note You need to log in before you can comment on or make changes to this bug.