Bug 52521

Summary: REGRESSION(r75708): Breaks Qt build if mobility is not installed. (Requested by benjaminp on #webkit).
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: New BugsAssignee: WebKit Review Bot <webkit.review.bot>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, commit-queue, eric, hausmann, ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 52525    
Bug Blocks: 51249    
Attachments:
Description Flags
ROLLOUT of r75708 none

WebKit Review Bot
Reported 2011-01-15 15:24:29 PST
http://trac.webkit.org/changeset/75708 broke the build: Breaks Qt build if mobility is not installed. (Requested by benjaminp on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear
Attachments
ROLLOUT of r75708 (25.18 KB, patch)
2011-01-15 15:24 PST, WebKit Review Bot 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
WebKit Review Bot
Comment 1 2011-01-15 15:24:51 PST
Created attachment 79080 [details] ROLLOUT of r75708 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID --ignore-builders where ATTACHMENT_ID is the ID of this attachment.
Benjamin Poulain
Comment 2 2011-01-15 15:27:29 PST
Comment on attachment 79080 [details] ROLLOUT of r75708 The fix is not trivial. I revert for now.
WebKit Commit Bot
Comment 3 2011-01-15 15:42:00 PST
Comment on attachment 79080 [details] ROLLOUT of r75708 Clearing flags on attachment: 79080 Committed r75885: <http://trac.webkit.org/changeset/75885>
WebKit Commit Bot
Comment 4 2011-01-15 15:42:07 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-01-15 18:38:12 PST
http://trac.webkit.org/changeset/75885 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/js/regexp-charclass-crash.html
Note You need to log in before you can comment on or make changes to this bug.