Summary: | Web Inspector: further split InspectorController meta bug. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, webkit.review.bot, yurys | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | 52532, 52797, 52955 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Pavel Feldman
2011-01-15 04:31:25 PST
Created attachment 79095 [details]
[PATCH] Proposed change
Attachment 79095 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebCore/inspector/InspectorInstrumentation.h:146: The parameter name "database" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorInstrumentation.h:154: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorInstrumentation.h:155: The parameter name "context" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorInstrumentation.h:254: The parameter name "database" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorController.h:157: The parameter name "frame" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/inspector/InspectorController.h:157: The parameter name "world" adds no information, so it should be removed. [readability/parameter_name] [5]
Total errors found: 6 in 24 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 79095 [details]
[PATCH] Proposed change
(attached to wrong bug)
|