Bug 52492 – ASSERT in VisibleSelection::setWithoutValidation when undoing text edit

• Component: HTML Editing
• Status: RESOLVED FIXED

[Dimitri Glazkov (Google)]

I've been running my browser in Debug just to see what type of fun things could happen. Here's one of them.

I was typing in the textarea for a while, and then started hitting Apple-Z. Hope this helps.

0x026b4285 in WebCore::VisibleSelection::setWithoutValidation (this=0x14869ff0, base=@0xbfffc840, extent=@0xbfffc834) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/VisibleSelection.cpp:435
435	    ASSERT(base != extent);
(gdb) bt
#0  0x026b4285 in WebCore::VisibleSelection::setWithoutValidation (this=0x14869ff0, base=@0xbfffc840, extent=@0xbfffc834) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/VisibleSelection.cpp:435
#1  0x0269b7b8 in WebCore::SelectionController::textWillBeReplaced (this=0x14869fe8, node=0x9e5ecd0, offset=0, oldLength=0, newLength=2024) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/SelectionController.cpp:291
#2  0x025806cb in WebCore::CharacterData::setDataAndUpdate (this=0x9e5ecd0, newData=@0xbfffc8c4, offsetOfReplacedData=0, oldLength=0, newLength=2024) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../dom/CharacterData.cpp:154
#3  0x02580b01 in WebCore::CharacterData::insertData (this=0x9e5ecd0, offset=0, data=@0xbfffc91c, ec=@0xbfffc918) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../dom/CharacterData.cpp:88
#4  0x0269ef11 in WebCore::SplitTextNodeCommand::doUnapply (this=0x15404040) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/SplitTextNodeCommand.cpp:79
#5  0x0265ecd0 in WebCore::EditCommand::unapply (this=0x15404040) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/EditCommand.cpp:120
#6  0x026545c6 in WebCore::CompositeEditCommand::doUnapply (this=0x15404e40) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/CompositeEditCommand.cpp:86
#7  0x0265ecd0 in WebCore::EditCommand::unapply (this=0x15404e40) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/EditCommand.cpp:120
#8  0x026545c6 in WebCore::CompositeEditCommand::doUnapply (this=0x16003110) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/CompositeEditCommand.cpp:86
#9  0x0265ecd0 in WebCore::EditCommand::unapply (this=0x16003110) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/EditCommand.cpp:120
#10 0x01f15919 in WebKit::EditorClientImpl::undo (this=0x9e189d4) at /Volumes/Work/cr1/src/third_party/WebKit/WebKit/chromium/src/EditorClientImpl.cpp:334
#11 0x02661535 in WebCore::Editor::undo (this=0x14869f30) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/Editor.cpp:1497
#12 0x02673599 in WebCore::executeUndo (frame=0x14869a00) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/EditorCommand.cpp:1046
#13 0x02672726 in WebCore::Editor::Command::execute (this=0xbfffcb2c, parameter=@0xbfffcb50, triggeringEvent=0x0) at /Volumes/Work/cr1/src/third_party/WebKit/Source/WebCore/WebCore.gyp/../editing/EditorCommand.cpp:1615
#14 0x01f54e8e in WebKit::WebFrameImpl::executeCommand (this=0x9e1a230, name=@0xbfffcba8) at /Volumes/Work/cr1/src/third_party/WebKit/WebKit/chromium/src/WebFrameImpl.cpp:1181
#15 0x00c97a61 in RenderView::OnUndo (this=0x14846e00) at /Volumes/Work/cr1/src/chrome/renderer/render_view.cc:1514
#16 0x00c9ec77 in IPC::Message::Dispatch<RenderView, RenderView> (msg=0x178004ac, obj=0x14846e00, sender=0x14846e00, func={__pfn = 0xc979f0 <RenderView::OnUndo()>, __delta = 0}) at ipc_message.h:136
#17 0x00c948fc in RenderView::OnMessageReceived (this=0x14846e00, message=@0x178004ac) at /Volumes/Work/cr1/src/chrome/re

[Ryosuke Niwa]

I'm certain my patch for https://bugs.webkit.org/show_bug.cgi?id=51389 will fix this bug.