Bug 52489

Summary: GraphicsLayers in subframes can get sync'd multiple times
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dev+webkit, simon.fraser, webkit-ews
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Preliminary cleanup.
none
Patch
none
Patch jamesr: review+

Simon Fraser (smfr)
Reported 2011-01-14 15:32:05 PST
FrameView::syncCompositingStateRecursive() calls sync on the root GraphicsLayer each frame, so when compositing layers are connected between frames, we'll end up syncing subframe's layers multiple times.
Attachments
Preliminary cleanup. (11.08 KB, text/plain)
2011-01-19 18:24 PST, Simon Fraser (smfr) 		no flags
Details
Patch (13.61 KB, text/plain)
2011-01-19 18:50 PST, Simon Fraser (smfr) 		no flags
Details
Patch (6.92 KB, patch)
2011-07-21 15:30 PDT, Simon Fraser (smfr) 		jamesr: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2011-01-19 18:24:59 PST
Created attachment 79535 [details] Preliminary cleanup.
Early Warning System Bot
Comment 2 2011-01-19 18:40:52 PST
Attachment 79535 [details] did not build on qt: Build output: http://queues.webkit.org/results/7498206
Build Bot
Comment 3 2011-01-19 18:46:34 PST
Attachment 79535 [details] did not build on win: Build output: http://queues.webkit.org/results/7507229
Simon Fraser (smfr)
Comment 4 2011-01-19 18:50:36 PST
Created attachment 79537 [details] Patch
Early Warning System Bot
Comment 5 2011-01-19 19:10:33 PST
Attachment 79537 [details] did not build on qt: Build output: http://queues.webkit.org/results/7612226
Sam Weinig
Comment 6 2011-01-19 19:18:42 PST
Comment on attachment 79537 [details] Patch Make sure to fix the Qt.
Simon Fraser (smfr)
Comment 7 2011-01-19 19:21:15 PST
Comment on attachment 79535 [details] Preliminary cleanup. http://trac.webkit.org/changeset/76196
Simon Fraser (smfr)
Comment 8 2011-01-19 19:21:44 PST
Comment on attachment 79537 [details] Patch Actually this one: http://trac.webkit.org/changeset/76196
Simon Fraser (smfr)
Comment 9 2011-07-21 15:30:57 PDT
Created attachment 101651 [details] Patch
James Robinson
Comment 10 2011-07-21 18:00:39 PDT
Comment on attachment 101651 [details] Patch Cool, R=me
Simon Fraser (smfr)
Comment 11 2011-07-21 18:02:50 PDT
http://trac.webkit.org/changeset/91542
Note You need to log in before you can comment on or make changes to this bug.