| Summary: | tweak line selection in code review tool | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> | ||||
| Component: | New Bugs | Assignee: | Ojan Vafai <ojan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, aroben, eric, mihaip | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Ojan Vafai
2011-01-14 11:39:02 PST
Created attachment 78970 [details]
Patch
Comment on attachment 78970 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78970&action=review I'm not sure I quite follow 100%, but this looks fine. > Websites/bugs.webkit.org/ChangeLog:14 > + -Make it so that if you click on the line immediately above > + a line that has a comment it will add a new comment instead of > + adding lines to the following comment. If the last selected line > + overlaps existing comment lines though they will still get > + added to the existing comment. Interesting. That's a nice refinement. One thing I'd like to do better is if you drag select a bunch of lines and then move your mouse backwards, you should "unselect" some lines. Currently, once selected, there is no unselect. (In reply to comment #2) > (From update of attachment 78970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78970&action=review > Interesting. That's a nice refinement. One thing I'd like to do better is if you drag select a bunch of lines and then move your mouse backwards, you should "unselect" some lines. Currently, once selected, there is no unselect. Oh. I thought that was by design. I'd be happy to fix this. Committed r75816: <http://trac.webkit.org/changeset/75816> |