Bug 52460

Summary: [Qt] Fixed compilation when QT_NO_SHORTCUT is defined
Product: WebKit Reporter: Konstantin Tokarev <annulen>
Component: WebKit QtAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: benjamin, commit-queue, kenneth, laszlo.gombos
Priority: P5 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Fixed compilation when QT_NO_SHORTCUT is defined
benjamin: review-
Fixed compilation when QT_NO_SHORTCUT is defined none

Konstantin Tokarev
Reported 2011-01-14 10:59:11 PST
This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt configuration
Attachments
Fixed compilation when QT_NO_SHORTCUT is defined (2.05 KB, patch)
2011-01-14 11:06 PST, Konstantin Tokarev 		benjamin: review-
DetailsFormatted DiffDiff
Fixed compilation when QT_NO_SHORTCUT is defined (2.25 KB, patch)
2011-01-14 11:24 PST, Konstantin Tokarev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Konstantin Tokarev
Comment 1 2011-01-14 11:06:48 PST
Created attachment 78964 [details] Fixed compilation when QT_NO_SHORTCUT is defined
Benjamin Poulain
Comment 2 2011-01-14 11:09:50 PST
Please follow this to report bugs on QtWebKit: http://trac.webkit.org/wiki/QtWebKitBugs By using the template, you get the "Qt" keyword and the bug appear in our lists.
Benjamin Poulain
Comment 3 2011-01-14 11:16:34 PST
Comment on attachment 78964 [details] Fixed compilation when QT_NO_SHORTCUT is defined View in context: https://bugs.webkit.org/attachment.cgi?id=78964&action=review > WebKit/qt/ChangeLog:8 > + This patch fixes compilation when QT_NO_SHORTCUT is defined in Qt configuration <Kenneth>A dot at the end of the sentence!</Kenneth> > WebKit/qt/WebCoreSupport/EditorClientQt.cpp:484 > +#ifndef QT_NO_SHORTCUT > } > - > +#endif I would rather see } else #endif // QT_NO_SHORTCUT { a dozen of lines above.
Benjamin Poulain
Comment 4 2011-01-14 11:17:17 PST
Adding Laszlo, he works on minimal builds.
Konstantin Tokarev
Comment 5 2011-01-14 11:24:48 PST
Created attachment 78967 [details] Fixed compilation when QT_NO_SHORTCUT is defined
Kenneth Rohde Christiansen
Comment 6 2011-01-14 11:52:19 PST
> <Kenneth>A dot at the end of the sentence!</Kenneth> hahaah :-) So much for enforcing the WebKit coding style! Actually it is not a real sentence without the punctuation mark at the end. :-)
Laszlo Gombos
Comment 7 2011-01-14 11:54:17 PST
Comment on attachment 78967 [details] Fixed compilation when QT_NO_SHORTCUT is defined LGTM, r+. Thanks.
WebKit Commit Bot
Comment 8 2011-01-14 12:44:02 PST
Comment on attachment 78967 [details] Fixed compilation when QT_NO_SHORTCUT is defined Clearing flags on attachment: 78967 Committed r75812: <http://trac.webkit.org/changeset/75812>
WebKit Commit Bot
Comment 9 2011-01-14 12:44:09 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.