| Summary: | Do some forward declaration in RenderStyle.h | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tony Gentilcore <tonyg> | ||||||||||||||
| Component: | New Bugs | Assignee: | Tony Gentilcore <tonyg> | ||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||
| Severity: | Normal | CC: | abarth, buildbot, dglazkov, eric, gustavo, webkit-ews, webkit.review.bot, xan.lopez | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Other | ||||||||||||||||
| OS: | OS X 10.5 | ||||||||||||||||
| Bug Depends on: | |||||||||||||||||
| Bug Blocks: | 52451 | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
|
Description
Tony Gentilcore
2011-01-14 09:27:57 PST
Created attachment 78949 [details]
Patch
Created attachment 78951 [details]
Patch
Attachment 78949 [details] did not build on qt: Build output: http://queues.webkit.org/results/7616030 Attachment 78951 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7603049 Attachment 78949 [details] did not build on win: Build output: http://queues.webkit.org/results/7558043 Attachment 78949 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7520056 Attachment 78951 [details] did not build on qt: Build output: http://queues.webkit.org/results/7506034 Attachment 78951 [details] did not build on win: Build output: http://queues.webkit.org/results/7588041 Attachment 78949 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7606037 Created attachment 78957 [details]
Patch
Attachment 78951 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7514038 Attachment 78957 [details] did not build on qt: Build output: http://queues.webkit.org/results/7626004 Comment on attachment 78957 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78957&action=review r+ (as long as it compiles). One small nit. > Source/WebCore/rendering/style/RenderStyle.h:91 > +struct ContentData; Nit: I would put the struct into a separate grouping (like what is done in Source/WebCore/html/HTMLFormElement.h for example). Attachment 78957 [details] did not build on win: Build output: http://queues.webkit.org/results/7549041 > r+ (as long as it compiles). The EWS bots will probably continue to find port-specific transitive deps. I won't land until they are all happy. > Nit: I would put the struct into a separate grouping (like what is done in Source/WebCore/html/HTMLFormElement.h for example). Done. Created attachment 78966 [details]
Patch
Attachment 78957 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7567040 Attachment 78957 [details] did not build on mac: Build output: http://queues.webkit.org/results/7580048 Attachment 78957 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7513047 Attachment 78966 [details] did not build on gtk: Build output: http://queues.webkit.org/results/7564048 Attachment 78966 [details] did not build on win: Build output: http://queues.webkit.org/results/7513048 Created attachment 78975 [details]
Patch
Attachment 78966 [details] did not build on qt: Build output: http://queues.webkit.org/results/7572048 Attachment 78966 [details] did not build on mac: Build output: http://queues.webkit.org/results/7612051 Created attachment 78985 [details]
Patch
Comment on attachment 78985 [details]
Patch
Same as before :)
Attachment 78985 [details] did not build on chromium: Build output: http://queues.webkit.org/results/7625031 Committed r75837: <http://trac.webkit.org/changeset/75837> http://trac.webkit.org/changeset/75837 might have broken Qt Linux Release minimal |