Bug 52429 – Web Inspector: extract InspectorSettings from InspectorState, simplify it.

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Pavel Feldman]

Patch to follow.

[Pavel Feldman]

Created attachment 78900 [details]
[PATCH] Proposed change

[Yury Semikhatsky]

Comment on attachment 78900 [details]
[PATCH] Proposed change

View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review

> Source/WebCore/inspector/InspectorController.cpp:194
>  {

These 4 methods should live in the WebKit layer.

> Source/WebCore/inspector/InspectorController.cpp:852
> +    m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled));

How will corresponding setting be changed when this property is modified on the state?

[Pavel Feldman]

(In reply to comment #2)
> (From update of attachment 78900 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review
> 
> > Source/WebCore/inspector/InspectorController.cpp:194
> >  {
> 
> These 4 methods should live in the WebKit layer.
> 

Yes, I remember you wanted to do that properly.

> > Source/WebCore/inspector/InspectorController.cpp:852
> > +    m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled));
> 
> How will corresponding setting be changed when this property is modified on the state?

See line 468.

[Pavel Feldman]

Landed as r75777.

[WebKit Review Bot]

http://trac.webkit.org/changeset/75777 might have broken GTK Linux 64-bit Debug