| Summary: | Web Inspector: extract InspectorSettings from InspectorState, simplify it. | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Pavel Feldman <pfeldman> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Pavel Feldman <pfeldman> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, apavlov, bweinstein, eric, joepeck, keishi, loislo, pfeldman, pmuellr, rik, timothy, webkit.review.bot, yurys | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Pavel Feldman
2011-01-14 00:37:13 PST
Created attachment 78900 [details]
[PATCH] Proposed change
Comment on attachment 78900 [details] [PATCH] Proposed change View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review > Source/WebCore/inspector/InspectorController.cpp:194 > { These 4 methods should live in the WebKit layer. > Source/WebCore/inspector/InspectorController.cpp:852 > + m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled)); How will corresponding setting be changed when this property is modified on the state? (In reply to comment #2) > (From update of attachment 78900 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=78900&action=review > > > Source/WebCore/inspector/InspectorController.cpp:194 > > { > > These 4 methods should live in the WebKit layer. > Yes, I remember you wanted to do that properly. > > Source/WebCore/inspector/InspectorController.cpp:852 > > + m_state->setBoolean(InspectorState::monitoringXHR, m_settings->getBoolean(InspectorSettings::MonitoringXHREnabled)); > > How will corresponding setting be changed when this property is modified on the state? See line 468. http://trac.webkit.org/changeset/75777 might have broken GTK Linux 64-bit Debug |