Bug 52421

Summary: Split out a MarkedSpace strategy object from Heap.
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: New BugsAssignee: Geoffrey Garen <ggaren>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch oliver: review+

Geoffrey Garen
Reported 2011-01-13 19:30:05 PST
Split out a MarkedSpace strategy object from Heap.
Attachments
patch (82.70 KB, patch)
2011-01-13 19:49 PST, Geoffrey Garen 		no flags
DetailsFormatted DiffDiff
patch (121.28 KB, patch)
2011-01-13 21:43 PST, Geoffrey Garen 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Geoffrey Garen
Comment 1 2011-01-13 19:49:36 PST
Created attachment 78884 [details] patch
Geoffrey Garen
Comment 2 2011-01-13 21:43:35 PST
Created attachment 78888 [details] patch
Oliver Hunt
Comment 3 2011-01-14 13:58:17 PST
Comment on attachment 78888 [details] patch r=me
Geoffrey Garen
Comment 4 2011-01-14 17:43:49 PST
Committed r75855: <http://trac.webkit.org/changeset/75855>
WebKit Review Bot
Comment 5 2011-01-14 19:12:13 PST
http://trac.webkit.org/changeset/75855 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/workers/shared-worker-shared.html fast/workers/worker-close-more.html fast/workers/worker-constructor.html http/tests/websocket/tests/workers/close-in-shared-worker.html http/tests/workers/shared-worker-importScripts.html http/tests/workers/worker-importScripts.html
Simon Fraser (smfr)
Comment 6 2011-01-14 19:54:03 PST
Boo: http://trac.webkit.org/changeset/75868
Simon Fraser (smfr)
Comment 7 2011-01-14 19:54:26 PST
BTW, did you ever run this? It asserted when launching Safari.
Geoffrey Garen
Comment 8 2011-01-15 15:59:50 PST
> Boo: http://trac.webkit.org/changeset/75868 Heh -- too late! I committed the same fix in http://trac.webkit.org/changeset/75866.
Note You need to log in before you can comment on or make changes to this bug.