Bug 52421 - Split out a MarkedSpace strategy object from Heap.
Summary: Split out a MarkedSpace strategy object from Heap.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-13 19:30 PST by Geoffrey Garen
Modified: 2011-01-15 15:59 PST (History)
4 users (show)

See Also:

Attachments
patch (82.70 KB, patch)
2011-01-13 19:49 PST, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
patch (121.28 KB, patch)
2011-01-13 21:43 PST, Geoffrey Garen 		oliver: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2011-01-13 19:30:05 PST 
Split out a MarkedSpace strategy object from Heap.
Comment 1 Geoffrey Garen 2011-01-13 19:49:36 PST 
Created attachment 78884 [details]
patch
Comment 2 Geoffrey Garen 2011-01-13 21:43:35 PST 
Created attachment 78888 [details]
patch
Comment 3 Oliver Hunt 2011-01-14 13:58:17 PST 
Comment on attachment 78888 [details]
patch

r=me
Comment 4 Geoffrey Garen 2011-01-14 17:43:49 PST 
Committed r75855: <http://trac.webkit.org/changeset/75855>
Comment 5 WebKit Review Bot 2011-01-14 19:12:13 PST 
http://trac.webkit.org/changeset/75855 might have broken GTK Linux 64-bit Debug
The following tests are not passing:
fast/workers/shared-worker-shared.html
fast/workers/worker-close-more.html
fast/workers/worker-constructor.html
http/tests/websocket/tests/workers/close-in-shared-worker.html
http/tests/workers/shared-worker-importScripts.html
http/tests/workers/worker-importScripts.html
Comment 6 Simon Fraser (smfr) 2011-01-14 19:54:03 PST 
Boo: http://trac.webkit.org/changeset/75868
Comment 7 Simon Fraser (smfr) 2011-01-14 19:54:26 PST 
BTW, did you ever run this? It asserted when launching Safari.
Comment 8 Geoffrey Garen 2011-01-15 15:59:50 PST 
> Boo: http://trac.webkit.org/changeset/75868

Heh -- too late! I committed the same fix in http://trac.webkit.org/changeset/75866.