Bug 52338

Summary:

Cleanup WebGLGetInfo and related get*Parameter helpers in WebGLRenderingContext

Product:

WebKit

Reporter:

Zhenyao Mo <zmo>

Component:

WebGL

Assignee:

Zhenyao Mo <zmo>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cmarrin, enne, kbr

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Bug Depends on:

51908

Bug Blocks:

Attachments:

Description	Flags
Patch	kbr: review+

Description Zhenyao Mo 2011-01-12 17:08:44 PST

Currently for example, we have getLongParameter/getIntParameter/getUnsignedLongParameter, and according to GL type def, we actually should use int and unsigned int.

Comment 1 Zhenyao Mo 2011-01-24 16:42:57 PST

Created attachment 79991 [details]
Patch

Comment 2 Kenneth Russell 2011-01-24 17:23:48 PST

Comment on attachment 79991 [details]
Patch

Looks fine; should we be referencing GC3D typedefs?

Comment 3 Zhenyao Mo 2011-01-24 17:32:28 PST

I thought about using GC3D types, but then again, we already have Float32Array, Int8Array, ect, which are using generic types, so I didn't see a lot of benefits for using GC3Dint and GC3Duint.

Comment 4 Zhenyao Mo 2011-01-25 09:40:12 PST

Committed r76601: <http://trac.webkit.org/changeset/76601>