Bug 52331

Summary: Get the new drawing area painting to the screen
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Anders Carlsson
Reported 2011-01-12 15:47:49 PST
Get the new drawing area painting to the screen
Attachments
Patch (4.89 KB, patch)
2011-01-12 15:51 PST, Anders Carlsson 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2011-01-12 15:51:48 PST
Created attachment 78750 [details] Patch
Sam Weinig
Comment 2 2011-01-12 15:55:50 PST
Comment on attachment 78750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=78750&action=review > WebKit2/UIProcess/mac/BackingStoreMac.mm:51 > + size_t sizeInBytes = CGBitmapContextGetBytesPerRow(m_bitmapContext.get()) * CGBitmapContextGetHeight(m_bitmapContext.get()); > + RetainPtr<CGDataProviderRef> dataProvider(AdoptCF, CGDataProviderCreateWithData(0, CGBitmapContextGetData(m_bitmapContext.get()), sizeInBytes, 0)); > + CGBitmapContextGetHeight(m_bitmapContext.get()), > + CGBitmapContextGetBitsPerPixel(m_bitmapContext.get()), > + CGBitmapContextGetBytesPerRow(m_bitmapContext.get()), > + CGBitmapContextGetColorSpace(m_bitmapContext.get()), > + CGBitmapContextGetBitmapInfo(m_bitmapContext.get()), > + dataProvider.get(), 0, false, kCGRenderingIntentDefault)); > + > + CGFloat imageWidth = CGImageGetWidth(image.get()); We should move this code to a shared function at somepoint. Please add a fixme.
Anders Carlsson
Comment 3 2011-01-12 16:41:27 PST
Committed r75657: <http://trac.webkit.org/changeset/75657>
Note You need to log in before you can comment on or make changes to this bug.