Bug 52307

Summary: Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
Product: WebKit Reporter: Maciej Stachowiak <mjs>
Component: New BugsAssignee: Maciej Stachowiak <mjs>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch darin: review+

Maciej Stachowiak
Reported 2011-01-12 10:41:49 PST
Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
Attachments
Patch (1.58 KB, patch)
2011-01-12 10:44 PST, Maciej Stachowiak 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Maciej Stachowiak
Comment 1 2011-01-12 10:44:35 PST
Created attachment 78705 [details] Patch
Maciej Stachowiak
Comment 2 2011-01-12 10:55:35 PST
Committed r75623: <http://trac.webkit.org/changeset/75623>
Adam Roben (:aroben)
Comment 3 2011-01-12 10:55:48 PST
Comment on attachment 78705 [details] Patch The review page seems broken at the moment, so reviewing this manually. +my $noBuildDumpTool = 0; I find positive names easier to understand, so I'd prefer: my $buildDumpTool = 1; + 'no-build' => \$noBuildDumpTool, Then this can become: 'build!' => \$buildDumpTool, That will support both --build and --no-build. You should add this new option to the usage notes. +if (!defined($root) && !$noBuildDumpTool) { This will of course have to change, too.
Note You need to log in before you can comment on or make changes to this bug.