| Summary: | Web Inspector: move lastWMLErrorMessage from Console to LayoutTestController | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yury Semikhatsky <yurys> | ||||
| Component: | Web Inspector (Deprecated) | Assignee: | Yury Semikhatsky <yurys> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | apavlov, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, staikos, timothy, yurys, zimmermann | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Yury Semikhatsky
2011-01-12 05:22:43 PST
I like this idea. I wonder if there is a way we can tell if it is still used anywhere in the wild. Although this would remove a public API and could technically break a website, it is really only for debugging code (as with all console.* functions) so I think this would be fine. I can't imagine anyone using this in the wild either. (In reply to comment #1) > I like this idea. I wonder if there is a way we can tell if it is still used anywhere in the wild. > Although this would remove a public API and could technically break a website, it is really > only for debugging code (as with all console.* functions) so I think this would be fine. I > can't imagine anyone using this in the wild either. This API never shipped, I only added it as debugging helper. Note that WML doesn't support JavaScript, so it was never reachable from a WML page.... (In reply to comment #2) > (In reply to comment #1) > > I like this idea. I wonder if there is a way we can tell if it is still used anywhere in the wild. > > Although this would remove a public API and could technically break a website, it is really > > only for debugging code (as with all console.* functions) so I think this would be fine. I > > can't imagine anyone using this in the wild either. > > This API never shipped, I only added it as debugging helper. Note that WML doesn't support JavaScript, so it was never reachable from a WML page.... There are three layout tests that call this method (http://codesearch.google.com/codesearch?hl=en&vert=chromium&lr=&q=lastWMLErrorMessage+file:LayoutTests&sbtn=Search), all of them are failing as I can see, should we remove them? Created attachment 78807 [details]
Patch
|